Commit 77a71432 authored by Dan Carpenter's avatar Dan Carpenter Committed by Tzung-Bi Shih

platform/chrome: cros_ec_lpc: Fix error code in cros_ec_lpc_mec_read_bytes()

We changed these functions to returning negative error codes, but this
first error path was accidentally overlooked.  It leads to a Smatch
warning:

    drivers/platform/chrome/cros_ec_lpc.c:181 ec_response_timed_out()
    error: uninitialized symbol 'data'.

Fix this by returning the error code instead of success.

Fixes: 68dbac0a ("platform/chrome: cros_ec_lpc: MEC access can return error code")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarGuenter Roeck <groeck@chromium.org>
Link: https://lore.kernel.org/r/e0b43fb5-ecc8-4fb4-9b76-c06dea8cc4c4@moroto.mountainSigned-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
parent c2a28647
...@@ -139,7 +139,7 @@ static int cros_ec_lpc_mec_read_bytes(unsigned int offset, unsigned int length, ...@@ -139,7 +139,7 @@ static int cros_ec_lpc_mec_read_bytes(unsigned int offset, unsigned int length,
int in_range = cros_ec_lpc_mec_in_range(offset, length); int in_range = cros_ec_lpc_mec_in_range(offset, length);
if (in_range < 0) if (in_range < 0)
return 0; return in_range;
return in_range ? return in_range ?
cros_ec_lpc_io_bytes_mec(MEC_IO_READ, cros_ec_lpc_io_bytes_mec(MEC_IO_READ,
...@@ -158,7 +158,7 @@ static int cros_ec_lpc_mec_write_bytes(unsigned int offset, unsigned int length, ...@@ -158,7 +158,7 @@ static int cros_ec_lpc_mec_write_bytes(unsigned int offset, unsigned int length,
int in_range = cros_ec_lpc_mec_in_range(offset, length); int in_range = cros_ec_lpc_mec_in_range(offset, length);
if (in_range < 0) if (in_range < 0)
return 0; return in_range;
return in_range ? return in_range ?
cros_ec_lpc_io_bytes_mec(MEC_IO_WRITE, cros_ec_lpc_io_bytes_mec(MEC_IO_WRITE,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment