Commit 78b0d99a authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Sam Ravnborg

drm/bridge: fix stack usage warning on old gcc

Some older versions of gcc badly optimize code that passes
an inline function argument into another function by reference,
causing huge stack usage:

drivers/gpu/drm/bridge/tc358768.c: In function 'tc358768_bridge_pre_enable':
drivers/gpu/drm/bridge/tc358768.c:840:1: error: the frame size of 2256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]

Use a temporary variable as a workaround and add a comment pointing
to the gcc bug.

Fixes: ff1ca639 ("drm/bridge: Add tc358768 driver")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200428215408.4111675-1-arnd@arndb.de
parent 6d4f3e2b
...@@ -178,6 +178,8 @@ static int tc358768_clear_error(struct tc358768_priv *priv) ...@@ -178,6 +178,8 @@ static int tc358768_clear_error(struct tc358768_priv *priv)
static void tc358768_write(struct tc358768_priv *priv, u32 reg, u32 val) static void tc358768_write(struct tc358768_priv *priv, u32 reg, u32 val)
{ {
/* work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715 */
int tmpval = val;
size_t count = 2; size_t count = 2;
if (priv->error) if (priv->error)
...@@ -187,7 +189,7 @@ static void tc358768_write(struct tc358768_priv *priv, u32 reg, u32 val) ...@@ -187,7 +189,7 @@ static void tc358768_write(struct tc358768_priv *priv, u32 reg, u32 val)
if (reg < 0x100 || reg >= 0x600) if (reg < 0x100 || reg >= 0x600)
count = 1; count = 1;
priv->error = regmap_bulk_write(priv->regmap, reg, &val, count); priv->error = regmap_bulk_write(priv->regmap, reg, &tmpval, count);
} }
static void tc358768_read(struct tc358768_priv *priv, u32 reg, u32 *val) static void tc358768_read(struct tc358768_priv *priv, u32 reg, u32 *val)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment