Commit 78d65a24 authored by Matthew Wilcox's avatar Matthew Wilcox Committed by Linus Torvalds

[PATCH] PCI Hotplug: Better reporting of PCI frequency / bus mode problems for acpi driver

When plugging a 33MHz card into a bus that's running at 66MHz, I'd like
to see a better error message than:

acpiphp_glue: notify_handler: unknown event type 0x5 for \_SB_.SBA0.PCI4.S2F0

The following patch would give us:

Device \_SB_.SBA0.PCI4.S2F0 cannot be configured due to a frequency mismatch

which I think is clearer.
parent b2d96267
...@@ -974,6 +974,21 @@ static void handle_hotplug_event_bridge (acpi_handle handle, u32 type, void *con ...@@ -974,6 +974,21 @@ static void handle_hotplug_event_bridge (acpi_handle handle, u32 type, void *con
dbg("%s: Device eject notify on %s\n", __FUNCTION__, objname); dbg("%s: Device eject notify on %s\n", __FUNCTION__, objname);
break; break;
case ACPI_NOTIFY_FREQUENCY_MISMATCH:
printk(KERN_ERR "Device %s cannot be configured due"
" to a frequency mismatch\n", objname);
break;
case ACPI_NOTIFY_BUS_MODE_MISMATCH:
printk(KERN_ERR "Device %s cannot be configured due"
" to a bus mode mismatch\n", objname);
break;
case ACPI_NOTIFY_POWER_FAULT:
printk(KERN_ERR "Device %s has suffered a power fault\n",
objname);
break;
default: default:
warn("notify_handler: unknown event type 0x%x for %s\n", type, objname); warn("notify_handler: unknown event type 0x%x for %s\n", type, objname);
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment