Commit 7998005b authored by Tejun Heo's avatar Tejun Heo

tty/max3100: don't use [delayed_]work_pending()

There's no need to test whether a (delayed) work item in pending
before queueing, flushing or cancelling it.  Most uses are unnecessary
and quite a few of them are buggy.

Remove unnecessary pending tests from max3100.  Only compile tested.
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>
parent 4d899be5
...@@ -179,8 +179,7 @@ static void max3100_work(struct work_struct *w); ...@@ -179,8 +179,7 @@ static void max3100_work(struct work_struct *w);
static void max3100_dowork(struct max3100_port *s) static void max3100_dowork(struct max3100_port *s)
{ {
if (!s->force_end_work && !work_pending(&s->work) && if (!s->force_end_work && !freezing(current) && !s->suspending)
!freezing(current) && !s->suspending)
queue_work(s->workqueue, &s->work); queue_work(s->workqueue, &s->work);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment