Commit 79ba4f93 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Jason Gunthorpe

IB/hfi1: Fix logical condition in msix_request_irq

Clang warns:

drivers/infiniband/hw/hfi1/msix.c:136:22: warning: overlapping
comparisons always evaluate to false [-Wtautological-overlap-compare]
        if (type < IRQ_SDMA && type >= IRQ_OTHER)
            ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
1 warning generated.

It is impossible for something to be less than 0 (IRQ_SDMA) and greater
than or equal to 3 (IRQ_OTHER) at the same time. A logical OR should
have been used to keep the same logic as before.

Link: https://lore.kernel.org/r/20200116222658.5285-1-natechancellor@gmail.com
Link: https://github.com/ClangBuiltLinux/linux/issues/841
Fixes: 13d2a838 ("IB/hfi1: Decouple IRQ name from type")
Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Acked-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 13e0af18
...@@ -133,7 +133,7 @@ static int msix_request_irq(struct hfi1_devdata *dd, void *arg, ...@@ -133,7 +133,7 @@ static int msix_request_irq(struct hfi1_devdata *dd, void *arg,
if (nr == dd->msix_info.max_requested) if (nr == dd->msix_info.max_requested)
return -ENOSPC; return -ENOSPC;
if (type < IRQ_SDMA && type >= IRQ_OTHER) if (type < IRQ_SDMA || type >= IRQ_OTHER)
return -EINVAL; return -EINVAL;
irq = pci_irq_vector(dd->pcidev, nr); irq = pci_irq_vector(dd->pcidev, nr);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment