Commit 79ff50c0 authored by Al Viro's avatar Al Viro

serial2002: switch to __vfs_read/__vfs_write

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent e1452866
...@@ -110,24 +110,16 @@ static int serial2002_tty_write(struct file *f, unsigned char *buf, int count) ...@@ -110,24 +110,16 @@ static int serial2002_tty_write(struct file *f, unsigned char *buf, int count)
{ {
const char __user *p = (__force const char __user *)buf; const char __user *p = (__force const char __user *)buf;
int result; int result;
loff_t offset = 0;
mm_segment_t oldfs; mm_segment_t oldfs;
oldfs = get_fs(); oldfs = get_fs();
set_fs(KERNEL_DS); set_fs(KERNEL_DS);
f->f_pos = 0; result = __vfs_write(f, p, count, &offset);
result = f->f_op->write(f, p, count, &f->f_pos);
set_fs(oldfs); set_fs(oldfs);
return result; return result;
} }
static int serial2002_tty_readb(struct file *f, unsigned char *buf)
{
char __user *p = (__force char __user *)buf;
f->f_pos = 0;
return f->f_op->read(f, p, 1, &f->f_pos);
}
static void serial2002_tty_read_poll_wait(struct file *f, int timeout) static void serial2002_tty_read_poll_wait(struct file *f, int timeout)
{ {
struct poll_wqueues table; struct poll_wqueues table;
...@@ -163,13 +155,15 @@ static int serial2002_tty_read(struct file *f, int timeout) ...@@ -163,13 +155,15 @@ static int serial2002_tty_read(struct file *f, int timeout)
result = -1; result = -1;
if (!IS_ERR(f)) { if (!IS_ERR(f)) {
mm_segment_t oldfs; mm_segment_t oldfs;
char __user *p = (__force char __user *)&ch;
loff_t offset = 0;
oldfs = get_fs(); oldfs = get_fs();
set_fs(KERNEL_DS); set_fs(KERNEL_DS);
if (f->f_op->poll) { if (f->f_op->poll) {
serial2002_tty_read_poll_wait(f, timeout); serial2002_tty_read_poll_wait(f, timeout);
if (serial2002_tty_readb(f, &ch) == 1) if (__vfs_read(f, p, 1, &offset) == 1)
result = ch; result = ch;
} else { } else {
/* Device does not support poll, busy wait */ /* Device does not support poll, busy wait */
...@@ -180,7 +174,7 @@ static int serial2002_tty_read(struct file *f, int timeout) ...@@ -180,7 +174,7 @@ static int serial2002_tty_read(struct file *f, int timeout)
if (retries >= timeout) if (retries >= timeout)
break; break;
if (serial2002_tty_readb(f, &ch) == 1) { if (__vfs_read(f, p, 1, &offset) == 1) {
result = ch; result = ch;
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment