Commit 7a3a16fe authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik

pata_legacy: don't call ata_host_detach() after initialization failure

ata_host_detach() detaches an attached port and shouldn't be called on
a port which hasn't been attached yet.  pata_legacy incorrectly calls
ata_host_detach() on unattached port after initialization failure
causing oops.  Fix it.
Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Arjan van de Ven <arjan@infradead.org>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 5ab063e3
...@@ -1278,8 +1278,6 @@ static __init int legacy_init_one(struct legacy_probe *probe) ...@@ -1278,8 +1278,6 @@ static __init int legacy_init_one(struct legacy_probe *probe)
} }
} }
fail: fail:
if (host)
ata_host_detach(host);
platform_device_unregister(pdev); platform_device_unregister(pdev);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment