Commit 7a6b1ab7 authored by David Ahern's avatar David Ahern Committed by David S. Miller

neighbour: allow NUD_NOARP entries to be forced GCed

IFF_POINTOPOINT interfaces use NUD_NOARP entries for IPv6. It's possible to
fill up the neighbour table with enough entries that it will overflow for
valid connections after that.

This behaviour is more prevalent after commit 58956317 ("neighbor:
Improve garbage collection") is applied, as it prevents removal from
entries that are not NUD_FAILED, unless they are more than 5s old.

Fixes: 58956317 (neighbor: Improve garbage collection)
Reported-by: default avatarKasper Dupont <kasperd@gjkwv.06.feb.2021.kasperd.net>
Signed-off-by: default avatarThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Signed-off-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a47c397b
...@@ -238,6 +238,7 @@ static int neigh_forced_gc(struct neigh_table *tbl) ...@@ -238,6 +238,7 @@ static int neigh_forced_gc(struct neigh_table *tbl)
write_lock(&n->lock); write_lock(&n->lock);
if ((n->nud_state == NUD_FAILED) || if ((n->nud_state == NUD_FAILED) ||
(n->nud_state == NUD_NOARP) ||
(tbl->is_multicast && (tbl->is_multicast &&
tbl->is_multicast(n->primary_key)) || tbl->is_multicast(n->primary_key)) ||
time_after(tref, n->updated)) time_after(tref, n->updated))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment