Commit 7aa9b96e authored by Aleksandr Mishin's avatar Aleksandr Mishin Committed by Bartosz Golaszewski

gpio: davinci: Validate the obtained number of IRQs

Value of pdata->gpio_unbanked is taken from Device Tree. In case of broken
DT due to any error this value can be any. Without this value validation
there can be out of chips->irqs array boundaries access in
davinci_gpio_probe().

Validate the obtained nirq value so that it won't exceed the maximum
number of IRQs per bank.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: eb3744a2 ("gpio: davinci: Do not assume continuous IRQ numbering")
Signed-off-by: default avatarAleksandr Mishin <amishin@t-argos.ru>
Link: https://lore.kernel.org/r/20240618144344.16943-1-amishin@t-argos.ruSigned-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent bfc6444b
...@@ -225,6 +225,11 @@ static int davinci_gpio_probe(struct platform_device *pdev) ...@@ -225,6 +225,11 @@ static int davinci_gpio_probe(struct platform_device *pdev)
else else
nirq = DIV_ROUND_UP(ngpio, 16); nirq = DIV_ROUND_UP(ngpio, 16);
if (nirq > MAX_INT_PER_BANK) {
dev_err(dev, "Too many IRQs!\n");
return -EINVAL;
}
chips = devm_kzalloc(dev, sizeof(*chips), GFP_KERNEL); chips = devm_kzalloc(dev, sizeof(*chips), GFP_KERNEL);
if (!chips) if (!chips)
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment