Commit 7b99a7c2 authored by Johannes Berg's avatar Johannes Berg Committed by John W. Linville

mac80211: fix sw scan locking

The recent scan overhaul broke locking
because now we can jump to code that
attempts to unlock, while we don't have
the mutex held. Fix this by holding the
mutex around all the relevant code.
Reported-by: default avatarBen Greear <greearb@candelatech.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 4b34d432
...@@ -681,8 +681,6 @@ void ieee80211_scan_work(struct work_struct *work) ...@@ -681,8 +681,6 @@ void ieee80211_scan_work(struct work_struct *work)
goto out_complete; goto out_complete;
} }
mutex_unlock(&local->mtx);
/* /*
* as long as no delay is required advance immediately * as long as no delay is required advance immediately
* without scheduling a new work * without scheduling a new work
...@@ -713,6 +711,7 @@ void ieee80211_scan_work(struct work_struct *work) ...@@ -713,6 +711,7 @@ void ieee80211_scan_work(struct work_struct *work)
} while (next_delay == 0); } while (next_delay == 0);
ieee80211_queue_delayed_work(&local->hw, &local->scan_work, next_delay); ieee80211_queue_delayed_work(&local->hw, &local->scan_work, next_delay);
mutex_unlock(&local->mtx);
return; return;
out_complete: out_complete:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment