Commit 7bc9f038 authored by Jacob Chen's avatar Jacob Chen Committed by Mauro Carvalho Chehab

media: i2c: OV5647: ensure clock lane in LP-11 state before streaming on

When I was supporting Rpi Camera Module on the ASUS Tinker board,
I found this driver have some issues with rockchip's mipi-csi driver.
It didn't place clock lane in LP-11 state before performing
D-PHY initialisation.

>From our experience, on some OV sensors,
LP-11 state is not achieved while BIT(5)-0x4800 is cleared.

So let's set BIT(5) and BIT(0) both while not streaming, in order to
coax the clock lane into LP-11 state.

0x4800 : MIPI CTRL 00
	BIT(5) : clock lane gate enable
		0: continuous
		1: none-continuous
	BIT(0) : manually set clock lane
		0: Not used
		1: used
Signed-off-by: default avatarJacob Chen <jacob-chen@iotwrt.com>
Reviewed-by: default avatarLuis Oliveira <lolivei@synopsys.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 71862f63
...@@ -253,6 +253,10 @@ static int ov5647_stream_on(struct v4l2_subdev *sd) ...@@ -253,6 +253,10 @@ static int ov5647_stream_on(struct v4l2_subdev *sd)
{ {
int ret; int ret;
ret = ov5647_write(sd, 0x4800, 0x04);
if (ret < 0)
return ret;
ret = ov5647_write(sd, 0x4202, 0x00); ret = ov5647_write(sd, 0x4202, 0x00);
if (ret < 0) if (ret < 0)
return ret; return ret;
...@@ -264,6 +268,10 @@ static int ov5647_stream_off(struct v4l2_subdev *sd) ...@@ -264,6 +268,10 @@ static int ov5647_stream_off(struct v4l2_subdev *sd)
{ {
int ret; int ret;
ret = ov5647_write(sd, 0x4800, 0x25);
if (ret < 0)
return ret;
ret = ov5647_write(sd, 0x4202, 0x0f); ret = ov5647_write(sd, 0x4202, 0x0f);
if (ret < 0) if (ret < 0)
return ret; return ret;
...@@ -320,7 +328,10 @@ static int __sensor_init(struct v4l2_subdev *sd) ...@@ -320,7 +328,10 @@ static int __sensor_init(struct v4l2_subdev *sd)
return ret; return ret;
} }
return ov5647_write(sd, 0x4800, 0x04); /*
* stream off to make the clock lane into LP-11 state.
*/
return ov5647_stream_off(sd);
} }
static int ov5647_sensor_power(struct v4l2_subdev *sd, int on) static int ov5647_sensor_power(struct v4l2_subdev *sd, int on)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment