Commit 7c486c0f authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab

[media] omap3isp: Don't ignore failure to locate external subdev

A failure to locate the external subdev for a non memory-to-memory
pipeline is a fatal error, don't ignore it.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: default avatarSakari Ailus <sakari.ailus@iki.fi>
Tested-by: default avatarPeter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent 4b2f1ed1
...@@ -886,7 +886,7 @@ static int isp_video_check_external_subdevs(struct isp_video *video, ...@@ -886,7 +886,7 @@ static int isp_video_check_external_subdevs(struct isp_video *video,
struct v4l2_ext_controls ctrls; struct v4l2_ext_controls ctrls;
struct v4l2_ext_control ctrl; struct v4l2_ext_control ctrl;
unsigned int i; unsigned int i;
int ret = 0; int ret;
/* Memory-to-memory pipelines have no external subdev. */ /* Memory-to-memory pipelines have no external subdev. */
if (pipe->input != NULL) if (pipe->input != NULL)
...@@ -909,7 +909,7 @@ static int isp_video_check_external_subdevs(struct isp_video *video, ...@@ -909,7 +909,7 @@ static int isp_video_check_external_subdevs(struct isp_video *video,
if (!source) { if (!source) {
dev_warn(isp->dev, "can't find source, failing now\n"); dev_warn(isp->dev, "can't find source, failing now\n");
return ret; return -EINVAL;
} }
if (media_entity_type(source) != MEDIA_ENT_T_V4L2_SUBDEV) if (media_entity_type(source) != MEDIA_ENT_T_V4L2_SUBDEV)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment