Commit 7d5dddda authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

USB: usb_wwan: remove some superfluous comments

Remove some more outdated or superfluous comments.
Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9fdf7063
...@@ -178,7 +178,6 @@ int usb_wwan_ioctl(struct tty_struct *tty, ...@@ -178,7 +178,6 @@ int usb_wwan_ioctl(struct tty_struct *tty,
} }
EXPORT_SYMBOL(usb_wwan_ioctl); EXPORT_SYMBOL(usb_wwan_ioctl);
/* Write */
int usb_wwan_write(struct tty_struct *tty, struct usb_serial_port *port, int usb_wwan_write(struct tty_struct *tty, struct usb_serial_port *port,
const unsigned char *buf, int count) const unsigned char *buf, int count)
{ {
...@@ -429,7 +428,6 @@ void usb_wwan_close(struct usb_serial_port *port) ...@@ -429,7 +428,6 @@ void usb_wwan_close(struct usb_serial_port *port)
portdata = usb_get_serial_port_data(port); portdata = usb_get_serial_port_data(port);
/* Stop reading/writing urbs */
spin_lock_irq(&intfdata->susp_lock); spin_lock_irq(&intfdata->susp_lock);
portdata->opened = 0; portdata->opened = 0;
if (--intfdata->open_ports == 0) if (--intfdata->open_ports == 0)
...@@ -454,7 +452,6 @@ void usb_wwan_close(struct usb_serial_port *port) ...@@ -454,7 +452,6 @@ void usb_wwan_close(struct usb_serial_port *port)
} }
EXPORT_SYMBOL(usb_wwan_close); EXPORT_SYMBOL(usb_wwan_close);
/* Helper functions used by usb_wwan_setup_urbs */
static struct urb *usb_wwan_setup_urb(struct usb_serial_port *port, static struct urb *usb_wwan_setup_urb(struct usb_serial_port *port,
int endpoint, int endpoint,
int dir, void *ctx, char *buf, int len, int dir, void *ctx, char *buf, int len,
...@@ -467,7 +464,6 @@ static struct urb *usb_wwan_setup_urb(struct usb_serial_port *port, ...@@ -467,7 +464,6 @@ static struct urb *usb_wwan_setup_urb(struct usb_serial_port *port,
if (!urb) if (!urb)
return NULL; return NULL;
/* Fill URB using supplied data. */
usb_fill_bulk_urb(urb, serial->dev, usb_fill_bulk_urb(urb, serial->dev,
usb_sndbulkpipe(serial->dev, endpoint) | dir, usb_sndbulkpipe(serial->dev, endpoint) | dir,
buf, len, callback, ctx); buf, len, callback, ctx);
...@@ -567,7 +563,6 @@ static void stop_urbs(struct usb_serial *serial) ...@@ -567,7 +563,6 @@ static void stop_urbs(struct usb_serial *serial)
struct usb_serial_port *port; struct usb_serial_port *port;
struct usb_wwan_port_private *portdata; struct usb_wwan_port_private *portdata;
/* Stop reading/writing urbs */
for (i = 0; i < serial->num_ports; ++i) { for (i = 0; i < serial->num_ports; ++i) {
port = serial->port[i]; port = serial->port[i];
portdata = usb_get_serial_port_data(port); portdata = usb_get_serial_port_data(port);
...@@ -648,11 +643,9 @@ int usb_wwan_resume(struct usb_serial *serial) ...@@ -648,11 +643,9 @@ int usb_wwan_resume(struct usb_serial *serial)
spin_lock_irq(&intfdata->susp_lock); spin_lock_irq(&intfdata->susp_lock);
for (i = 0; i < serial->num_ports; i++) { for (i = 0; i < serial->num_ports; i++) {
/* walk all ports */
port = serial->port[i]; port = serial->port[i];
portdata = usb_get_serial_port_data(port); portdata = usb_get_serial_port_data(port);
/* skip closed ports */
if (!portdata || !portdata->opened) if (!portdata || !portdata->opened)
continue; continue;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment