Commit 7d8c19bf authored by Yang Yingliang's avatar Yang Yingliang Committed by Jakub Kicinski

net: plip: don't call kfree_skb/dev_kfree_skb() under spin_lock_irq()

It is not allowed to call kfree_skb() or consume_skb() from
hardware interrupt context or with interrupts being disabled.
So replace kfree_skb/dev_kfree_skb() with dev_kfree_skb_irq()
and dev_consume_skb_irq() under spin_lock_irq().

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20221207015310.2984909-1-yangyingliang@huawei.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5f4d487d
...@@ -450,12 +450,12 @@ plip_bh_timeout_error(struct net_device *dev, struct net_local *nl, ...@@ -450,12 +450,12 @@ plip_bh_timeout_error(struct net_device *dev, struct net_local *nl,
} }
rcv->state = PLIP_PK_DONE; rcv->state = PLIP_PK_DONE;
if (rcv->skb) { if (rcv->skb) {
kfree_skb(rcv->skb); dev_kfree_skb_irq(rcv->skb);
rcv->skb = NULL; rcv->skb = NULL;
} }
snd->state = PLIP_PK_DONE; snd->state = PLIP_PK_DONE;
if (snd->skb) { if (snd->skb) {
dev_kfree_skb(snd->skb); dev_consume_skb_irq(snd->skb);
snd->skb = NULL; snd->skb = NULL;
} }
spin_unlock_irq(&nl->lock); spin_unlock_irq(&nl->lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment