Commit 7dad9ef6 authored by Julia Lawall's avatar Julia Lawall Committed by Ben Skeggs

drivers/gpu/drm/nouveau/nouveau_grctx.c: correct NULL test

Test the just-allocated value for NULL rather than some other value.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,y;
statement S;
@@

x = \(kmalloc\|kcalloc\|kzalloc\)(...);
(
if ((x) == NULL) S
|
if (
-   y
+   x
       == NULL)
 S
)
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Cc: David Airlie <airlied@linux.ie>
Cc: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
parent f0fbe3eb
...@@ -97,8 +97,8 @@ nouveau_grctx_prog_load(struct drm_device *dev) ...@@ -97,8 +97,8 @@ nouveau_grctx_prog_load(struct drm_device *dev)
} }
pgraph->ctxvals = kmalloc(fw->size, GFP_KERNEL); pgraph->ctxvals = kmalloc(fw->size, GFP_KERNEL);
if (!pgraph->ctxprog) { if (!pgraph->ctxvals) {
NV_ERROR(dev, "OOM copying ctxprog\n"); NV_ERROR(dev, "OOM copying ctxvals\n");
release_firmware(fw); release_firmware(fw);
nouveau_grctx_fini(dev); nouveau_grctx_fini(dev);
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment