Commit 7dc70220 authored by Andrey Shvetsov's avatar Andrey Shvetsov Committed by Greg Kroah-Hartman

staging: most: core: consolidate channel attributes

This patch replaces 13 temporary variables representing the attributes
to control the channel with an array of 13 elements to keep the
corresponding code compact.
Signed-off-by: default avatarAndrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: default avatarChristian Gromm <christian.gromm@microchip.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1c74e3ab
...@@ -333,17 +333,6 @@ static ssize_t channel_starving_show(struct most_c_obj *c, ...@@ -333,17 +333,6 @@ static ssize_t channel_starving_show(struct most_c_obj *c,
return snprintf(buf, PAGE_SIZE, "%d\n", c->is_starving); return snprintf(buf, PAGE_SIZE, "%d\n", c->is_starving);
} }
#define create_show_channel_attribute(val) \
static struct most_c_attr most_chnl_attr_##val = __ATTR_RO(val)
create_show_channel_attribute(available_directions);
create_show_channel_attribute(available_datatypes);
create_show_channel_attribute(number_of_packet_buffers);
create_show_channel_attribute(number_of_stream_buffers);
create_show_channel_attribute(size_of_stream_buffer);
create_show_channel_attribute(size_of_packet_buffer);
create_show_channel_attribute(channel_starving);
static ssize_t set_number_of_buffers_show(struct most_c_obj *c, static ssize_t set_number_of_buffers_show(struct most_c_obj *c,
struct most_c_attr *attr, struct most_c_attr *attr,
char *buf) char *buf)
...@@ -485,33 +474,39 @@ static ssize_t set_packets_per_xact_store(struct most_c_obj *c, ...@@ -485,33 +474,39 @@ static ssize_t set_packets_per_xact_store(struct most_c_obj *c,
return count; return count;
} }
#define create_channel_attribute(value) \ static struct most_c_attr most_c_attrs[] = {
static struct most_c_attr most_chnl_attr_##value = __ATTR_RW(value) __ATTR_RO(available_directions),
__ATTR_RO(available_datatypes),
create_channel_attribute(set_buffer_size); __ATTR_RO(number_of_packet_buffers),
create_channel_attribute(set_number_of_buffers); __ATTR_RO(number_of_stream_buffers),
create_channel_attribute(set_direction); __ATTR_RO(size_of_stream_buffer),
create_channel_attribute(set_datatype); __ATTR_RO(size_of_packet_buffer),
create_channel_attribute(set_subbuffer_size); __ATTR_RO(channel_starving),
create_channel_attribute(set_packets_per_xact); __ATTR_RW(set_buffer_size),
__ATTR_RW(set_number_of_buffers),
__ATTR_RW(set_direction),
__ATTR_RW(set_datatype),
__ATTR_RW(set_subbuffer_size),
__ATTR_RW(set_packets_per_xact),
};
/** /**
* most_channel_def_attrs - array of default attributes of channel object * most_channel_def_attrs - array of default attributes of channel object
*/ */
static struct attribute *most_channel_def_attrs[] = { static struct attribute *most_channel_def_attrs[] = {
&most_chnl_attr_available_directions.attr, &most_c_attrs[0].attr,
&most_chnl_attr_available_datatypes.attr, &most_c_attrs[1].attr,
&most_chnl_attr_number_of_packet_buffers.attr, &most_c_attrs[2].attr,
&most_chnl_attr_number_of_stream_buffers.attr, &most_c_attrs[3].attr,
&most_chnl_attr_size_of_packet_buffer.attr, &most_c_attrs[4].attr,
&most_chnl_attr_size_of_stream_buffer.attr, &most_c_attrs[5].attr,
&most_chnl_attr_set_number_of_buffers.attr, &most_c_attrs[6].attr,
&most_chnl_attr_set_buffer_size.attr, &most_c_attrs[7].attr,
&most_chnl_attr_set_direction.attr, &most_c_attrs[8].attr,
&most_chnl_attr_set_datatype.attr, &most_c_attrs[9].attr,
&most_chnl_attr_set_subbuffer_size.attr, &most_c_attrs[10].attr,
&most_chnl_attr_set_packets_per_xact.attr, &most_c_attrs[11].attr,
&most_chnl_attr_channel_starving.attr, &most_c_attrs[12].attr,
NULL, NULL,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment