Commit 7dde07e9 authored by Dan Carpenter's avatar Dan Carpenter Committed by Pablo Neira Ayuso

netfilter: x_tables: unlock on error in xt_find_table_lock()

According to my static checker we should unlock here before the return.
That seems reasonable to me as well.

Fixes" b9e69e12 ("netfilter: xtables: don't hook tables by default")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 9dd2ab60
...@@ -1051,8 +1051,10 @@ struct xt_table *xt_find_table_lock(struct net *net, u_int8_t af, ...@@ -1051,8 +1051,10 @@ struct xt_table *xt_find_table_lock(struct net *net, u_int8_t af,
list_for_each_entry(t, &init_net.xt.tables[af], list) { list_for_each_entry(t, &init_net.xt.tables[af], list) {
if (strcmp(t->name, name)) if (strcmp(t->name, name))
continue; continue;
if (!try_module_get(t->me)) if (!try_module_get(t->me)) {
mutex_unlock(&xt[af].mutex);
return NULL; return NULL;
}
mutex_unlock(&xt[af].mutex); mutex_unlock(&xt[af].mutex);
if (t->table_init(net) != 0) { if (t->table_init(net) != 0) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment