Commit 7e2804aa authored by Anssi Hannula's avatar Anssi Hannula Committed by Marc Kleine-Budde

can: xilinx_can: only report warning and passive states on state changes

The xilinx_can driver currently increments error-warning and
error-passive statistics on every error interrupt regardless of whether
the interface was already in the same state. Similarly, the error frame
sent on error interrupts is always sent with
CAN_ERR_CRTL_(RX|TX)_(PASSIVE|WARNING) bit set.

To make the error-warning and error-passive statistics more useful, add
a check to only set the error state when the state has actually been
changed.

Tested with the integrated CAN on Zynq-7000 SoC.
Signed-off-by: default avatarAnssi Hannula <anssi.hannula@bitwise.fi>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent c8d4dea2
...@@ -703,6 +703,7 @@ static void xcan_err_interrupt(struct net_device *ndev, u32 isr) ...@@ -703,6 +703,7 @@ static void xcan_err_interrupt(struct net_device *ndev, u32 isr)
} else { } else {
enum can_state new_state = xcan_current_error_state(ndev); enum can_state new_state = xcan_current_error_state(ndev);
if (new_state != priv->can.state)
xcan_set_error_state(ndev, new_state, skb ? cf : NULL); xcan_set_error_state(ndev, new_state, skb ? cf : NULL);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment