Commit 7e4a32c0 authored by Hyunmin Lee's avatar Hyunmin Lee Committed by Andrew Morton

mm/vmalloc: replace BUG_ON with a simple if statement

As per the coding standards, in the event of an abnormal condition that
should not occur under normal circumstances, the kernel should attempt
recovery and proceed with execution, rather than halting the machine.

Specifically, in the alloc_vmap_area() function, use a simple if()
instead of using BUG_ON() halting the machine.

Link: https://lkml.kernel.org/r/20230201115142.GA7772@min-iamrootCo-developed-by: default avatarGwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Signed-off-by: default avatarGwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Co-developed-by: default avatarJeungwoo Yoo <casionwoo@gmail.com>
Signed-off-by: default avatarJeungwoo Yoo <casionwoo@gmail.com>
Co-developed-by: default avatarSangyun Kim <sangyun.kim@snu.ac.kr>
Signed-off-by: default avatarSangyun Kim <sangyun.kim@snu.ac.kr>
Signed-off-by: default avatarHyunmin Lee <hn.min.lee@gmail.com>
Reviewed-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: default avatarHyeonggon Yoo <42.hyeyoo@gmail.com>
Reviewed-by: default avatarMike Rapoport (IBM) <rppt@kernel.org>
Reviewed-by: default avatarUladzislau Rezki (Sony) <urezki@gmail.com>
Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 1d693a3e
...@@ -1586,9 +1586,8 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, ...@@ -1586,9 +1586,8 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
int purged = 0; int purged = 0;
int ret; int ret;
BUG_ON(!size); if (unlikely(!size || offset_in_page(size) || !is_power_of_2(align)))
BUG_ON(offset_in_page(size)); return ERR_PTR(-EINVAL);
BUG_ON(!is_power_of_2(align));
if (unlikely(!vmap_initialized)) if (unlikely(!vmap_initialized))
return ERR_PTR(-EBUSY); return ERR_PTR(-EBUSY);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment