Commit 7f6fc502 authored by Ji-Ze Hong (Peter Hong)'s avatar Ji-Ze Hong (Peter Hong) Committed by Johan Hovold

USB: serial: f81232: implement break control

Implement Fintek F81232 break on/off with LCR register.
It's the same with 16550A LCR register layout.
Signed-off-by: default avatarJi-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
[ johan: fix corrupt line settings on break due to missing shadow_lcr
  update in set_termios() ]
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 268ddb5e
...@@ -65,6 +65,7 @@ struct f81232_private { ...@@ -65,6 +65,7 @@ struct f81232_private {
struct mutex lock; struct mutex lock;
u8 modem_control; u8 modem_control;
u8 modem_status; u8 modem_status;
u8 shadow_lcr;
speed_t baud_base; speed_t baud_base;
struct work_struct lsr_work; struct work_struct lsr_work;
struct work_struct interrupt_work; struct work_struct interrupt_work;
...@@ -377,13 +378,23 @@ static void f81232_process_read_urb(struct urb *urb) ...@@ -377,13 +378,23 @@ static void f81232_process_read_urb(struct urb *urb)
static void f81232_break_ctl(struct tty_struct *tty, int break_state) static void f81232_break_ctl(struct tty_struct *tty, int break_state)
{ {
/* FIXME - Stubbed out for now */ struct usb_serial_port *port = tty->driver_data;
struct f81232_private *priv = usb_get_serial_port_data(port);
int status;
/* mutex_lock(&priv->lock);
* break_state = -1 to turn on break, and 0 to turn off break
* see drivers/char/tty_io.c to see it used. if (break_state)
* last_set_data_urb_value NEVER has the break bit set in it. priv->shadow_lcr |= UART_LCR_SBC;
*/ else
priv->shadow_lcr &= ~UART_LCR_SBC;
status = f81232_set_register(port, LINE_CONTROL_REGISTER,
priv->shadow_lcr);
if (status)
dev_err(&port->dev, "set break failed: %d\n", status);
mutex_unlock(&priv->lock);
} }
static int f81232_find_clk(speed_t baudrate) static int f81232_find_clk(speed_t baudrate)
...@@ -519,6 +530,7 @@ static int f81232_port_disable(struct usb_serial_port *port) ...@@ -519,6 +530,7 @@ static int f81232_port_disable(struct usb_serial_port *port)
static void f81232_set_termios(struct tty_struct *tty, static void f81232_set_termios(struct tty_struct *tty,
struct usb_serial_port *port, struct ktermios *old_termios) struct usb_serial_port *port, struct ktermios *old_termios)
{ {
struct f81232_private *priv = usb_get_serial_port_data(port);
u8 new_lcr = 0; u8 new_lcr = 0;
int status = 0; int status = 0;
speed_t baudrate; speed_t baudrate;
...@@ -572,11 +584,18 @@ static void f81232_set_termios(struct tty_struct *tty, ...@@ -572,11 +584,18 @@ static void f81232_set_termios(struct tty_struct *tty,
break; break;
} }
mutex_lock(&priv->lock);
new_lcr |= (priv->shadow_lcr & UART_LCR_SBC);
status = f81232_set_register(port, LINE_CONTROL_REGISTER, new_lcr); status = f81232_set_register(port, LINE_CONTROL_REGISTER, new_lcr);
if (status) { if (status) {
dev_err(&port->dev, "%s failed to set LCR: %d\n", dev_err(&port->dev, "%s failed to set LCR: %d\n",
__func__, status); __func__, status);
} }
priv->shadow_lcr = new_lcr;
mutex_unlock(&priv->lock);
} }
static int f81232_tiocmget(struct tty_struct *tty) static int f81232_tiocmget(struct tty_struct *tty)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment