Commit 7f715626 authored by Liad Kaufman's avatar Liad Kaufman Committed by Emmanuel Grumbach

iwlwifi: use dev_printk instead of dev_dbg for debug logs

When calling IWL_DEBUG_*() dev_dbg() is currently used, and this
could result in the log being ignored no matter the internal
loglevel, since dev_dbg() may get turned on or off based on the
dynamic debug mechanism.

Replace the dev_dbg() with dev_printk() since dynamic printing
is pointless as we use our own debug level mechanism and there
is just a single dev_dbg() call in the code.
Signed-off-by: default avatarLiad Kaufman <liad.kaufman@intel.com>
[rephrase commit message a bit]
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent a1022927
...@@ -61,8 +61,6 @@ ...@@ -61,8 +61,6 @@
* *
*****************************************************************************/ *****************************************************************************/
#define DEBUG
#include <linux/device.h> #include <linux/device.h>
#include <linux/interrupt.h> #include <linux/interrupt.h>
#include <linux/export.h> #include <linux/export.h>
...@@ -128,8 +126,8 @@ void __iwl_dbg(struct device *dev, ...@@ -128,8 +126,8 @@ void __iwl_dbg(struct device *dev,
#ifdef CONFIG_IWLWIFI_DEBUG #ifdef CONFIG_IWLWIFI_DEBUG
if (iwl_have_debug_level(level) && if (iwl_have_debug_level(level) &&
(!limit || net_ratelimit())) (!limit || net_ratelimit()))
dev_dbg(dev, "%c %s %pV", in_interrupt() ? 'I' : 'U', dev_printk(KERN_DEBUG, dev, "%c %s %pV",
function, &vaf); in_interrupt() ? 'I' : 'U', function, &vaf);
#endif #endif
trace_iwlwifi_dbg(level, in_interrupt(), function, &vaf); trace_iwlwifi_dbg(level, in_interrupt(), function, &vaf);
va_end(args); va_end(args);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment