Commit 7f9e88e6 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller

net: socionext: Fix a signedness bug in ave_probe()

The "phy_mode" variable is an enum and in this context GCC treats it as
an unsigned int so the error handling is never triggered.

Fixes: 4c270b55 ("net: ethernet: socionext: add AVE ethernet driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarKunihiko Hayashi <hayashi.kunihiko@socionext.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ced81eb8
...@@ -1566,7 +1566,7 @@ static int ave_probe(struct platform_device *pdev) ...@@ -1566,7 +1566,7 @@ static int ave_probe(struct platform_device *pdev)
np = dev->of_node; np = dev->of_node;
phy_mode = of_get_phy_mode(np); phy_mode = of_get_phy_mode(np);
if (phy_mode < 0) { if ((int)phy_mode < 0) {
dev_err(dev, "phy-mode not found\n"); dev_err(dev, "phy-mode not found\n");
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment