Commit 7fe23b5d authored by Dave Kleikamp's avatar Dave Kleikamp Committed by Chris Wright

[PATCH] JFS: Fix race waking up jfsIO kernel thread

It's possible for a journal I/O request to be added to the log_redrive
queue and the jfsIO thread to be awakened after the thread releases
log_redrive_lock but before it sets its state to TASK_INTERRUPTIBLE.

The jfsIO thread should set the state before giving up the spinlock, so
the waking thread will really wake it.
Signed-off-by: default avatarDave Kleikamp <shaggy@linux.vnet.ibm.com>
Signed-off-by: default avatarChris Wright <chrisw@sous-sol.org>
parent 81166863
...@@ -2354,12 +2354,13 @@ int jfsIOWait(void *arg) ...@@ -2354,12 +2354,13 @@ int jfsIOWait(void *arg)
lbmStartIO(bp); lbmStartIO(bp);
spin_lock_irq(&log_redrive_lock); spin_lock_irq(&log_redrive_lock);
} }
spin_unlock_irq(&log_redrive_lock);
if (freezing(current)) { if (freezing(current)) {
spin_unlock_irq(&log_redrive_lock);
refrigerator(); refrigerator();
} else { } else {
set_current_state(TASK_INTERRUPTIBLE); set_current_state(TASK_INTERRUPTIBLE);
spin_unlock_irq(&log_redrive_lock);
schedule(); schedule();
current->state = TASK_RUNNING; current->state = TASK_RUNNING;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment