Commit 80b4a0f8 authored by Valentin Rothberg's avatar Valentin Rothberg Committed by Felipe Balbi

usb: isp1760: set IRQ flags properly

The IRQF_DISABLED is a NOOP and scheduled to be removed.  According to
commit e58aa3d2 ("genirq: Run irq handlers with interrupts
disabled") running IRQ handlers with interrupts enabled can cause stack
overflows when the interrupt line of the issuing device is still active.

This patch removes using this deprecated flag and additionally removes
redundantly setting IRQF_SHARED for isp1760_udc_register().
Signed-off-by: default avatarValentin Rothberg <Valentin.Rothberg@lip6.fr>
Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 1c390eb3
...@@ -151,8 +151,7 @@ int isp1760_register(struct resource *mem, int irq, unsigned long irqflags, ...@@ -151,8 +151,7 @@ int isp1760_register(struct resource *mem, int irq, unsigned long irqflags,
} }
if (IS_ENABLED(CONFIG_USB_ISP1761_UDC) && !udc_disabled) { if (IS_ENABLED(CONFIG_USB_ISP1761_UDC) && !udc_disabled) {
ret = isp1760_udc_register(isp, irq, irqflags | IRQF_SHARED | ret = isp1760_udc_register(isp, irq, irqflags);
IRQF_DISABLED);
if (ret < 0) { if (ret < 0) {
isp1760_hcd_unregister(&isp->hcd); isp1760_hcd_unregister(&isp->hcd);
return ret; return ret;
......
...@@ -1453,8 +1453,8 @@ int isp1760_udc_register(struct isp1760_device *isp, int irq, ...@@ -1453,8 +1453,8 @@ int isp1760_udc_register(struct isp1760_device *isp, int irq,
sprintf(udc->irqname, "%s (udc)", devname); sprintf(udc->irqname, "%s (udc)", devname);
ret = request_irq(irq, isp1760_udc_irq, IRQF_SHARED | IRQF_DISABLED | ret = request_irq(irq, isp1760_udc_irq, IRQF_SHARED | irqflags,
irqflags, udc->irqname, udc); udc->irqname, udc);
if (ret < 0) if (ret < 0)
goto error; goto error;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment