Commit 80fbc2d9 authored by Shawn Guo's avatar Shawn Guo Committed by Linus Walleij

pinctrl: zte: fix group_desc initialization

There are a couple of issues with group_desc initialization in function
zx_pinctrl_build_state().

 - num_pins is not initialized and remains zero.
 - pins shouldn't be initialized with a pointer to variable in the
   stack.

With them fixed, pin_request() in pinmux_enable_setting() can be invoked
correctly.
Signed-off-by: default avatarShawn Guo <shawn.guo@linaro.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent dcbcc304
...@@ -282,10 +282,10 @@ static int zx_pinctrl_build_state(struct platform_device *pdev) ...@@ -282,10 +282,10 @@ static int zx_pinctrl_build_state(struct platform_device *pdev)
for (i = 0; i < ngroups; i++) { for (i = 0; i < ngroups; i++) {
const struct pinctrl_pin_desc *pindesc = info->pins + i; const struct pinctrl_pin_desc *pindesc = info->pins + i;
struct group_desc *group = groups + i; struct group_desc *group = groups + i;
int id = pindesc->number;
group->name = pindesc->name; group->name = pindesc->name;
group->pins = &id; group->pins = (int *) &pindesc->number;
group->num_pins = 1;
radix_tree_insert(&pctldev->pin_group_tree, i, group); radix_tree_insert(&pctldev->pin_group_tree, i, group);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment