Commit 819baf88 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jon Mason

ntb_perf: potential info leak in debugfs

This is a static checker warning, not something I'm desperately
concerned about.  But snprintf() returns the number of bytes that
would have been copied if there were space.  We really care about the
number of bytes that actually were copied so we should use scnprintf()
instead.

It probably won't overrun, and in that case we may as well just use
sprintf() but these sorts of things make static checkers and code
reviewers happier.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarDave Jiang <dave.jiang@intel.com>
Signed-off-by: default avatarJon Mason <jdmason@kudzu.us>
parent 25ea9f2b
...@@ -589,7 +589,7 @@ static ssize_t debugfs_run_read(struct file *filp, char __user *ubuf, ...@@ -589,7 +589,7 @@ static ssize_t debugfs_run_read(struct file *filp, char __user *ubuf,
return -ENOMEM; return -ENOMEM;
if (mutex_is_locked(&perf->run_mutex)) { if (mutex_is_locked(&perf->run_mutex)) {
out_off = snprintf(buf, 64, "running\n"); out_off = scnprintf(buf, 64, "running\n");
goto read_from_buf; goto read_from_buf;
} }
...@@ -600,14 +600,14 @@ static ssize_t debugfs_run_read(struct file *filp, char __user *ubuf, ...@@ -600,14 +600,14 @@ static ssize_t debugfs_run_read(struct file *filp, char __user *ubuf,
break; break;
if (pctx->status) { if (pctx->status) {
out_off += snprintf(buf + out_off, 1024 - out_off, out_off += scnprintf(buf + out_off, 1024 - out_off,
"%d: error %d\n", i, "%d: error %d\n", i,
pctx->status); pctx->status);
continue; continue;
} }
rate = div64_u64(pctx->copied, pctx->diff_us); rate = div64_u64(pctx->copied, pctx->diff_us);
out_off += snprintf(buf + out_off, 1024 - out_off, out_off += scnprintf(buf + out_off, 1024 - out_off,
"%d: copied %llu bytes in %llu usecs, %llu MBytes/s\n", "%d: copied %llu bytes in %llu usecs, %llu MBytes/s\n",
i, pctx->copied, pctx->diff_us, rate); i, pctx->copied, pctx->diff_us, rate);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment