Commit 81f1eca6 authored by Benjamin Herrenschmidt's avatar Benjamin Herrenschmidt Committed by David S. Miller

ftgmac100: Request the interrupt only after HW is reset

The interrupt isn't shared, so this will keep it masked
until we have the HW in a known sane state.
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b8dbecff
...@@ -1131,12 +1131,6 @@ static int ftgmac100_open(struct net_device *netdev) ...@@ -1131,12 +1131,6 @@ static int ftgmac100_open(struct net_device *netdev)
if (ftgmac100_alloc_rx_buffers(priv)) if (ftgmac100_alloc_rx_buffers(priv))
goto err_alloc; goto err_alloc;
err = request_irq(netdev->irq, ftgmac100_interrupt, 0, netdev->name, netdev);
if (err) {
netdev_err(netdev, "failed to request irq %d\n", netdev->irq);
goto err_irq;
}
/* When using NC-SI we force the speed to 100Mbit/s full duplex, /* When using NC-SI we force the speed to 100Mbit/s full duplex,
* *
* Otherwise we leave it set to 0 (no link), the link * Otherwise we leave it set to 0 (no link), the link
...@@ -1163,6 +1157,13 @@ static int ftgmac100_open(struct net_device *netdev) ...@@ -1163,6 +1157,13 @@ static int ftgmac100_open(struct net_device *netdev)
/* Initialize NAPI */ /* Initialize NAPI */
netif_napi_add(netdev, &priv->napi, ftgmac100_poll, 64); netif_napi_add(netdev, &priv->napi, ftgmac100_poll, 64);
/* Grab our interrupt */
err = request_irq(netdev->irq, ftgmac100_interrupt, 0, netdev->name, netdev);
if (err) {
netdev_err(netdev, "failed to request irq %d\n", netdev->irq);
goto err_irq;
}
ftgmac100_init_hw(priv); ftgmac100_init_hw(priv);
ftgmac100_start_hw(priv); ftgmac100_start_hw(priv);
...@@ -1193,12 +1194,12 @@ static int ftgmac100_open(struct net_device *netdev) ...@@ -1193,12 +1194,12 @@ static int ftgmac100_open(struct net_device *netdev)
err_ncsi: err_ncsi:
napi_disable(&priv->napi); napi_disable(&priv->napi);
netif_stop_queue(netdev); netif_stop_queue(netdev);
netif_napi_del(&priv->napi);
iowrite32(0, priv->base + FTGMAC100_OFFSET_IER);
err_hw:
free_irq(netdev->irq, netdev); free_irq(netdev->irq, netdev);
err_irq: err_irq:
netif_napi_del(&priv->napi);
err_hw:
err_alloc: err_alloc:
iowrite32(0, priv->base + FTGMAC100_OFFSET_IER);
ftgmac100_free_buffers(priv); ftgmac100_free_buffers(priv);
ftgmac100_free_rings(priv); ftgmac100_free_rings(priv);
return err; return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment