Commit 82d53603 authored by Nicholas Bellinger's avatar Nicholas Bellinger Committed by Greg Kroah-Hartman

iscsi-target: Fix memory corruption in iscsit_logout_post_handler_diffcid

commit b53b0d99 upstream.

This patch fixes a bug in iscsit_logout_post_handler_diffcid() where
a pointer used as storage for list_for_each_entry() was incorrectly
being used to determine if no matching entry had been found.

This patch changes iscsit_logout_post_handler_diffcid() to key off
bool conn_found to determine if the function needs to exit early.
Reported-by: default avatarJoern Engel <joern@logfs.org>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 718846f8
...@@ -4540,6 +4540,7 @@ static void iscsit_logout_post_handler_diffcid( ...@@ -4540,6 +4540,7 @@ static void iscsit_logout_post_handler_diffcid(
{ {
struct iscsi_conn *l_conn; struct iscsi_conn *l_conn;
struct iscsi_session *sess = conn->sess; struct iscsi_session *sess = conn->sess;
bool conn_found = false;
if (!sess) if (!sess)
return; return;
...@@ -4548,12 +4549,13 @@ static void iscsit_logout_post_handler_diffcid( ...@@ -4548,12 +4549,13 @@ static void iscsit_logout_post_handler_diffcid(
list_for_each_entry(l_conn, &sess->sess_conn_list, conn_list) { list_for_each_entry(l_conn, &sess->sess_conn_list, conn_list) {
if (l_conn->cid == cid) { if (l_conn->cid == cid) {
iscsit_inc_conn_usage_count(l_conn); iscsit_inc_conn_usage_count(l_conn);
conn_found = true;
break; break;
} }
} }
spin_unlock_bh(&sess->conn_lock); spin_unlock_bh(&sess->conn_lock);
if (!l_conn) if (!conn_found)
return; return;
if (l_conn->sock) if (l_conn->sock)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment