Commit 82d8eb40 authored by Rhyland Klein's avatar Rhyland Klein Committed by Lee Jones

mfd: max77620: Fix FPS switch statements

When configuring FPS during probe, assuming a DT node is present for
FPS, the code can run into a problem with the switch statements in
max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely,
in the case of chip->chip_id == MAX77620, it will set
fps_[mix|max]_period but then fall through to the default switch case
and return -EINVAL. Returning this from max77620_config_fps() will
cause probe to fail.
Signed-off-by: default avatarRhyland Klein <rklein@nvidia.com>
Reviewed-by: default avatarLaxman Dewangan <ldewangan@nvidia.com>
Reviewed-by: default avatarThierry Reding <treding@nvidia.com>
Tested-by: default avatarThierry Reding <treding@nvidia.com>
Tested-by: default avatarAlexandre Courbot <acourbot@nvidia.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 9278e707
...@@ -203,6 +203,7 @@ static int max77620_get_fps_period_reg_value(struct max77620_chip *chip, ...@@ -203,6 +203,7 @@ static int max77620_get_fps_period_reg_value(struct max77620_chip *chip,
break; break;
case MAX77620: case MAX77620:
fps_min_period = MAX77620_FPS_PERIOD_MIN_US; fps_min_period = MAX77620_FPS_PERIOD_MIN_US;
break;
default: default:
return -EINVAL; return -EINVAL;
} }
...@@ -236,6 +237,7 @@ static int max77620_config_fps(struct max77620_chip *chip, ...@@ -236,6 +237,7 @@ static int max77620_config_fps(struct max77620_chip *chip,
break; break;
case MAX77620: case MAX77620:
fps_max_period = MAX77620_FPS_PERIOD_MAX_US; fps_max_period = MAX77620_FPS_PERIOD_MAX_US;
break;
default: default:
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment