Commit 830f8b91 authored by Gerlando Falauto's avatar Gerlando Falauto Committed by Jason Cooper

arm: plat-orion: fix printing of "MPP config unavailable on this hardware"

refactored printing of the kernel warning:

"orion_mpp_conf: requested MPP%u config unavailable on this hardware\n"

which is not to be printed in case of variant_mask = 0 (unknown variant).
This check should be performed using a logical AND (&&) as opposed
to a bitwise AND (&).

Otherwise, test would fail (and message would not be printed) if
variant_mask != 1
Signed-off-by: default avatarGerlando Falauto <gerlando.falauto@keymile.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Olof Johansson <olof@lixom.net>
Cc: Nicolas Pitre <nico@linaro.org>
Cc: Holger Brunck <holger.brunck@keymile.com>
Acked-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarJason Cooper <jason@lakedaemon.net>
parent fd2704e8
...@@ -49,7 +49,7 @@ void __init orion_mpp_conf(unsigned int *mpp_list, unsigned int variant_mask, ...@@ -49,7 +49,7 @@ void __init orion_mpp_conf(unsigned int *mpp_list, unsigned int variant_mask,
"number (%u)\n", num); "number (%u)\n", num);
continue; continue;
} }
if (variant_mask & !(*mpp_list & variant_mask)) { if (variant_mask && !(*mpp_list & variant_mask)) {
printk(KERN_WARNING printk(KERN_WARNING
"orion_mpp_conf: requested MPP%u config " "orion_mpp_conf: requested MPP%u config "
"unavailable on this hardware\n", num); "unavailable on this hardware\n", num);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment