Commit 830fafce authored by Rob Herring's avatar Rob Herring Committed by Lee Jones

mfd: Use device_get_match_data() in a bunch of drivers

Use preferred device_get_match_data() instead of of_match_device() to
get the driver match data. With this, adjust the includes to explicitly
include the correct headers.
Reviewed-by: default avatarChen-Yu Tsai <wens@csie.org>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20231017203612.2701060-1-robh@kernel.orgSigned-off-by: default avatarLee Jones <lee@kernel.org>
parent 15d71e67
...@@ -22,7 +22,8 @@ ...@@ -22,7 +22,8 @@
#include <linux/mfd/axp20x.h> #include <linux/mfd/axp20x.h>
#include <linux/mfd/core.h> #include <linux/mfd/core.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/of_device.h> #include <linux/of.h>
#include <linux/property.h>
#include <linux/reboot.h> #include <linux/reboot.h>
#include <linux/regmap.h> #include <linux/regmap.h>
#include <linux/regulator/consumer.h> #include <linux/regulator/consumer.h>
...@@ -1131,27 +1132,10 @@ static int axp20x_power_off(struct sys_off_data *data) ...@@ -1131,27 +1132,10 @@ static int axp20x_power_off(struct sys_off_data *data)
int axp20x_match_device(struct axp20x_dev *axp20x) int axp20x_match_device(struct axp20x_dev *axp20x)
{ {
struct device *dev = axp20x->dev; struct device *dev = axp20x->dev;
const struct acpi_device_id *acpi_id;
const struct of_device_id *of_id;
const struct mfd_cell *cells_no_irq = NULL; const struct mfd_cell *cells_no_irq = NULL;
int nr_cells_no_irq = 0; int nr_cells_no_irq = 0;
if (dev->of_node) { axp20x->variant = (long)device_get_match_data(dev);
of_id = of_match_device(dev->driver->of_match_table, dev);
if (!of_id) {
dev_err(dev, "Unable to match OF ID\n");
return -ENODEV;
}
axp20x->variant = (long)of_id->data;
} else {
acpi_id = acpi_match_device(dev->driver->acpi_match_table, dev);
if (!acpi_id || !acpi_id->driver_data) {
dev_err(dev, "Unable to match ACPI ID and data\n");
return -ENODEV;
}
axp20x->variant = (long)acpi_id->driver_data;
}
switch (axp20x->variant) { switch (axp20x->variant) {
case AXP152_ID: case AXP152_ID:
axp20x->nr_cells = ARRAY_SIZE(axp152_cells); axp20x->nr_cells = ARRAY_SIZE(axp152_cells);
......
...@@ -15,8 +15,9 @@ ...@@ -15,8 +15,9 @@
#include <linux/mfd/core.h> #include <linux/mfd/core.h>
#include <linux/mfd/hi6421-pmic.h> #include <linux/mfd/hi6421-pmic.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/of_device.h> #include <linux/of.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/property.h>
#include <linux/regmap.h> #include <linux/regmap.h>
static const struct mfd_cell hi6421_devs[] = { static const struct mfd_cell hi6421_devs[] = {
...@@ -50,16 +51,12 @@ MODULE_DEVICE_TABLE(of, of_hi6421_pmic_match); ...@@ -50,16 +51,12 @@ MODULE_DEVICE_TABLE(of, of_hi6421_pmic_match);
static int hi6421_pmic_probe(struct platform_device *pdev) static int hi6421_pmic_probe(struct platform_device *pdev)
{ {
struct hi6421_pmic *pmic; struct hi6421_pmic *pmic;
const struct of_device_id *id;
const struct mfd_cell *subdevs; const struct mfd_cell *subdevs;
enum hi6421_type type; enum hi6421_type type;
void __iomem *base; void __iomem *base;
int n_subdevs, ret; int n_subdevs, ret;
id = of_match_device(of_hi6421_pmic_match, &pdev->dev); type = (uintptr_t)device_get_match_data(&pdev->dev);
if (!id)
return -EINVAL;
type = (uintptr_t)id->data;
pmic = devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL); pmic = devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL);
if (!pmic) if (!pmic)
......
...@@ -16,8 +16,8 @@ ...@@ -16,8 +16,8 @@
#include <linux/mfd/mxs-lradc.h> #include <linux/mfd/mxs-lradc.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/of.h> #include <linux/of.h>
#include <linux/of_device.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/property.h>
#include <linux/slab.h> #include <linux/slab.h>
#define ADC_CELL 0 #define ADC_CELL 0
...@@ -125,7 +125,6 @@ MODULE_DEVICE_TABLE(of, mxs_lradc_dt_ids); ...@@ -125,7 +125,6 @@ MODULE_DEVICE_TABLE(of, mxs_lradc_dt_ids);
static int mxs_lradc_probe(struct platform_device *pdev) static int mxs_lradc_probe(struct platform_device *pdev)
{ {
const struct of_device_id *of_id;
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct device_node *node = dev->of_node; struct device_node *node = dev->of_node;
struct mxs_lradc *lradc; struct mxs_lradc *lradc;
...@@ -138,11 +137,7 @@ static int mxs_lradc_probe(struct platform_device *pdev) ...@@ -138,11 +137,7 @@ static int mxs_lradc_probe(struct platform_device *pdev)
if (!lradc) if (!lradc)
return -ENOMEM; return -ENOMEM;
of_id = of_match_device(mxs_lradc_dt_ids, &pdev->dev); lradc->soc = (enum mxs_lradc_id)device_get_match_data(&pdev->dev);
if (!of_id)
return -EINVAL;
lradc->soc = (uintptr_t)of_id->data;
lradc->clk = devm_clk_get(&pdev->dev, NULL); lradc->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(lradc->clk)) { if (IS_ERR(lradc->clk)) {
......
...@@ -8,10 +8,12 @@ ...@@ -8,10 +8,12 @@
#include <linux/gfp.h> #include <linux/gfp.h>
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/of_platform.h>
#include <linux/spmi.h> #include <linux/spmi.h>
#include <linux/types.h> #include <linux/types.h>
#include <linux/regmap.h> #include <linux/regmap.h>
#include <linux/of_platform.h>
#include <soc/qcom/qcom-spmi-pmic.h> #include <soc/qcom/qcom-spmi-pmic.h>
#define PMIC_REV2 0x101 #define PMIC_REV2 0x101
...@@ -264,7 +266,7 @@ static int pmic_spmi_probe(struct spmi_device *sdev) ...@@ -264,7 +266,7 @@ static int pmic_spmi_probe(struct spmi_device *sdev)
if (!ctx) if (!ctx)
return -ENOMEM; return -ENOMEM;
ctx->num_usids = (uintptr_t)of_device_get_match_data(&sdev->dev); ctx->num_usids = (uintptr_t)device_get_match_data(&sdev->dev);
/* Only the first slave id for a PMIC contains this information */ /* Only the first slave id for a PMIC contains this information */
if (sdev->usid % ctx->num_usids == 0) { if (sdev->usid % ctx->num_usids == 0) {
......
...@@ -7,6 +7,8 @@ ...@@ -7,6 +7,8 @@
#include <linux/module.h> #include <linux/module.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/property.h>
#include <linux/of.h>
#include <linux/of_platform.h> #include <linux/of_platform.h>
#include <linux/io.h> #include <linux/io.h>
#include <linux/interrupt.h> #include <linux/interrupt.h>
...@@ -528,7 +530,6 @@ static irqreturn_t qcom_rpm_wakeup_interrupt(int irq, void *dev) ...@@ -528,7 +530,6 @@ static irqreturn_t qcom_rpm_wakeup_interrupt(int irq, void *dev)
static int qcom_rpm_probe(struct platform_device *pdev) static int qcom_rpm_probe(struct platform_device *pdev)
{ {
const struct of_device_id *match;
struct device_node *syscon_np; struct device_node *syscon_np;
struct qcom_rpm *rpm; struct qcom_rpm *rpm;
u32 fw_version[3]; u32 fw_version[3];
...@@ -570,10 +571,9 @@ static int qcom_rpm_probe(struct platform_device *pdev) ...@@ -570,10 +571,9 @@ static int qcom_rpm_probe(struct platform_device *pdev)
if (irq_wakeup < 0) if (irq_wakeup < 0)
return irq_wakeup; return irq_wakeup;
match = of_match_device(qcom_rpm_of_match, &pdev->dev); rpm->data = device_get_match_data(&pdev->dev);
if (!match) if (!rpm->data)
return -ENODEV; return -ENODEV;
rpm->data = match->data;
rpm->status_regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); rpm->status_regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(rpm->status_regs)) if (IS_ERR(rpm->status_regs))
......
...@@ -19,7 +19,7 @@ ...@@ -19,7 +19,7 @@
#include <linux/regmap.h> #include <linux/regmap.h>
#include <linux/mfd/tps65910.h> #include <linux/mfd/tps65910.h>
#include <linux/of.h> #include <linux/of.h>
#include <linux/of_device.h> #include <linux/property.h>
static const struct resource rtc_resources[] = { static const struct resource rtc_resources[] = {
{ {
...@@ -374,16 +374,9 @@ static struct tps65910_board *tps65910_parse_dt(struct i2c_client *client, ...@@ -374,16 +374,9 @@ static struct tps65910_board *tps65910_parse_dt(struct i2c_client *client,
struct device_node *np = client->dev.of_node; struct device_node *np = client->dev.of_node;
struct tps65910_board *board_info; struct tps65910_board *board_info;
unsigned int prop; unsigned int prop;
const struct of_device_id *match;
int ret; int ret;
match = of_match_device(tps65910_of_match, &client->dev); *chip_id = (unsigned long)device_get_match_data(&client->dev);
if (!match) {
dev_err(&client->dev, "Failed to find matching dt id\n");
return NULL;
}
*chip_id = (unsigned long)match->data;
board_info = devm_kzalloc(&client->dev, sizeof(*board_info), board_info = devm_kzalloc(&client->dev, sizeof(*board_info),
GFP_KERNEL); GFP_KERNEL);
......
...@@ -27,8 +27,8 @@ ...@@ -27,8 +27,8 @@
#include <linux/pm.h> #include <linux/pm.h>
#include <linux/mfd/twl.h> #include <linux/mfd/twl.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/property.h>
#include <linux/of.h> #include <linux/of.h>
#include <linux/of_device.h>
#include <asm/mach-types.h> #include <asm/mach-types.h>
...@@ -883,7 +883,6 @@ static int twl4030_power_probe(struct platform_device *pdev) ...@@ -883,7 +883,6 @@ static int twl4030_power_probe(struct platform_device *pdev)
{ {
const struct twl4030_power_data *pdata = dev_get_platdata(&pdev->dev); const struct twl4030_power_data *pdata = dev_get_platdata(&pdev->dev);
struct device_node *node = pdev->dev.of_node; struct device_node *node = pdev->dev.of_node;
const struct of_device_id *match;
int err = 0; int err = 0;
int err2 = 0; int err2 = 0;
u8 val; u8 val;
...@@ -904,10 +903,8 @@ static int twl4030_power_probe(struct platform_device *pdev) ...@@ -904,10 +903,8 @@ static int twl4030_power_probe(struct platform_device *pdev)
return err; return err;
} }
match = of_match_device(of_match_ptr(twl4030_power_of_match), if (node)
&pdev->dev); pdata = device_get_match_data(&pdev->dev);
if (match && match->data)
pdata = match->data;
if (pdata) { if (pdata) {
err = twl4030_power_configure_scripts(pdata); err = twl4030_power_configure_scripts(pdata);
......
...@@ -24,10 +24,10 @@ ...@@ -24,10 +24,10 @@
#include <linux/kthread.h> #include <linux/kthread.h>
#include <linux/mfd/twl.h> #include <linux/mfd/twl.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/property.h>
#include <linux/suspend.h> #include <linux/suspend.h>
#include <linux/of.h> #include <linux/of.h>
#include <linux/irqdomain.h> #include <linux/irqdomain.h>
#include <linux/of_device.h>
#include "twl-core.h" #include "twl-core.h"
...@@ -368,10 +368,10 @@ int twl6030_init_irq(struct device *dev, int irq_num) ...@@ -368,10 +368,10 @@ int twl6030_init_irq(struct device *dev, int irq_num)
int nr_irqs; int nr_irqs;
int status; int status;
u8 mask[3]; u8 mask[3];
const struct of_device_id *of_id; const int *irq_tbl;
of_id = of_match_device(twl6030_of_match, dev); irq_tbl = device_get_match_data(dev);
if (!of_id || !of_id->data) { if (!irq_tbl) {
dev_err(dev, "Unknown TWL device model\n"); dev_err(dev, "Unknown TWL device model\n");
return -EINVAL; return -EINVAL;
} }
...@@ -409,7 +409,7 @@ int twl6030_init_irq(struct device *dev, int irq_num) ...@@ -409,7 +409,7 @@ int twl6030_init_irq(struct device *dev, int irq_num)
twl6030_irq->pm_nb.notifier_call = twl6030_irq_pm_notifier; twl6030_irq->pm_nb.notifier_call = twl6030_irq_pm_notifier;
atomic_set(&twl6030_irq->wakeirqs, 0); atomic_set(&twl6030_irq->wakeirqs, 0);
twl6030_irq->irq_mapping_tbl = of_id->data; twl6030_irq->irq_mapping_tbl = irq_tbl;
twl6030_irq->irq_domain = twl6030_irq->irq_domain =
irq_domain_add_linear(node, nr_irqs, irq_domain_add_linear(node, nr_irqs,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment