Commit 8391d07b authored by Dimitris Michailidis's avatar Dimitris Michailidis Committed by David S. Miller

ipv4: Remove leftover rcu_read_unlock calls from __mkroute_output()

Commit "fib: RCU conversion of fib_lookup()" removed rcu_read_lock() from
__mkroute_output but left a couple of calls to rcu_read_unlock() in there.
This causes lockdep to complain that the rcu_read_unlock() call in
__ip_route_output_key causes a lock inbalance and quickly crashes the
kernel. The below fixes this for me.
Signed-off-by: default avatarDimitris Michailidis <dm@chelsio.com>
Acked-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 993284df
...@@ -2396,12 +2396,10 @@ static int __mkroute_output(struct rtable **result, ...@@ -2396,12 +2396,10 @@ static int __mkroute_output(struct rtable **result,
rth = dst_alloc(&ipv4_dst_ops); rth = dst_alloc(&ipv4_dst_ops);
if (!rth) { if (!rth)
rcu_read_unlock();
return -ENOBUFS; return -ENOBUFS;
}
in_dev_hold(in_dev); in_dev_hold(in_dev);
rcu_read_unlock();
rth->idev = in_dev; rth->idev = in_dev;
atomic_set(&rth->dst.__refcnt, 1); atomic_set(&rth->dst.__refcnt, 1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment