Commit 8428a8eb authored by Takashi Iwai's avatar Takashi Iwai

ALSA: usb-audio: Fix potential zero-division at parsing FU

parse_audio_feature_unit() contains a code dividing potentially with
zero when a malformed FU descriptor is passed.  Although there is
already a sanity check, it checks only the value zero, hence it can
still lead to a zero-division when a value 1 is passed there.

Fix it by correcting the sanity check (and the error message
thereof).

Fixes: 23caaf19 ("ALSA: usb-mixer: Add support for Audio Class v2.0")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f658f17b
...@@ -1476,9 +1476,9 @@ static int parse_audio_feature_unit(struct mixer_build *state, int unitid, ...@@ -1476,9 +1476,9 @@ static int parse_audio_feature_unit(struct mixer_build *state, int unitid,
return -EINVAL; return -EINVAL;
} }
csize = hdr->bControlSize; csize = hdr->bControlSize;
if (!csize) { if (csize <= 1) {
usb_audio_dbg(state->chip, usb_audio_dbg(state->chip,
"unit %u: invalid bControlSize == 0\n", "unit %u: invalid bControlSize <= 1\n",
unitid); unitid);
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment