Commit 846df244 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

misc: pci_endpoint_test: Avoid triggering a BUG()

If you call ida_simple_remove(&pci_endpoint_test_ida, id) with a
negative "id" then it triggers an immediate BUG_ON().  Let's not allow
that.

Fixes: 2c156ac7 ("misc: Add host side PCI driver for PCI test function device")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 378f79ca
...@@ -597,6 +597,8 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev) ...@@ -597,6 +597,8 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev)
if (sscanf(misc_device->name, DRV_MODULE_NAME ".%d", &id) != 1) if (sscanf(misc_device->name, DRV_MODULE_NAME ".%d", &id) != 1)
return; return;
if (id < 0)
return;
misc_deregister(&test->miscdev); misc_deregister(&test->miscdev);
ida_simple_remove(&pci_endpoint_test_ida, id); ida_simple_remove(&pci_endpoint_test_ida, id);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment