Commit 849ef928 authored by David Sterba's avatar David Sterba Committed by Chris Mason

btrfs: check unsupported filters in balance arguments

We don't verify that all the balance filter arguments supplemented by
the flags are actually known to the kernel. Thus we let it silently pass
and do nothing.

At the moment this means only the 'limit' filter, but we're going to add
a few more soon so it's better to have that fixed. Also in older stable
kernels so that it works with newer userspace tools.

Cc: stable@vger.kernel.org # 3.16+
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarChris Mason <clm@fb.com>
parent b06c4bf5
...@@ -4691,6 +4691,11 @@ static long btrfs_ioctl_balance(struct file *file, void __user *arg) ...@@ -4691,6 +4691,11 @@ static long btrfs_ioctl_balance(struct file *file, void __user *arg)
bctl->flags |= BTRFS_BALANCE_TYPE_MASK; bctl->flags |= BTRFS_BALANCE_TYPE_MASK;
} }
if (bctl->flags & ~(BTRFS_BALANCE_ARGS_MASK | BTRFS_BALANCE_TYPE_MASK)) {
ret = -EINVAL;
goto out_bargs;
}
do_balance: do_balance:
/* /*
* Ownership of bctl and mutually_exclusive_operation_running * Ownership of bctl and mutually_exclusive_operation_running
......
...@@ -381,6 +381,14 @@ struct map_lookup { ...@@ -381,6 +381,14 @@ struct map_lookup {
#define BTRFS_BALANCE_ARGS_VRANGE (1ULL << 4) #define BTRFS_BALANCE_ARGS_VRANGE (1ULL << 4)
#define BTRFS_BALANCE_ARGS_LIMIT (1ULL << 5) #define BTRFS_BALANCE_ARGS_LIMIT (1ULL << 5)
#define BTRFS_BALANCE_ARGS_MASK \
(BTRFS_BALANCE_ARGS_PROFILES | \
BTRFS_BALANCE_ARGS_USAGE | \
BTRFS_BALANCE_ARGS_DEVID | \
BTRFS_BALANCE_ARGS_DRANGE | \
BTRFS_BALANCE_ARGS_VRANGE | \
BTRFS_BALANCE_ARGS_LIMIT)
/* /*
* Profile changing flags. When SOFT is set we won't relocate chunk if * Profile changing flags. When SOFT is set we won't relocate chunk if
* it already has the target profile (even though it may be * it already has the target profile (even though it may be
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment