Commit 84c08517 authored by Daniel Vetter's avatar Daniel Vetter

drm: Unexport drm_plane_helper_check_update

It's for legacy drivers only (atomic ones should use
drm_atomic_helper_check_plane_state() instead), and there's no users
left except the one in the primary plane helpers.
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181004202446.22905-18-daniel.vetter@ffwll.ch
parent 40e3defd
...@@ -97,43 +97,17 @@ static int get_connectors_for_crtc(struct drm_crtc *crtc, ...@@ -97,43 +97,17 @@ static int get_connectors_for_crtc(struct drm_crtc *crtc,
return count; return count;
} }
/** static int drm_plane_helper_check_update(struct drm_plane *plane,
* drm_plane_helper_check_update() - Check plane update for validity struct drm_crtc *crtc,
* @plane: plane object to update struct drm_framebuffer *fb,
* @crtc: owning CRTC of owning plane struct drm_rect *src,
* @fb: framebuffer to flip onto plane struct drm_rect *dst,
* @src: source coordinates in 16.16 fixed point unsigned int rotation,
* @dst: integer destination coordinates int min_scale,
* @rotation: plane rotation int max_scale,
* @min_scale: minimum @src:@dest scaling factor in 16.16 fixed point bool can_position,
* @max_scale: maximum @src:@dest scaling factor in 16.16 fixed point bool can_update_disabled,
* @can_position: is it legal to position the plane such that it bool *visible)
* doesn't cover the entire crtc? This will generally
* only be false for primary planes.
* @can_update_disabled: can the plane be updated while the crtc
* is disabled?
* @visible: output parameter indicating whether plane is still visible after
* clipping
*
* Checks that a desired plane update is valid. Drivers that provide
* their own plane handling rather than helper-provided implementations may
* still wish to call this function to avoid duplication of error checking
* code.
*
* RETURNS:
* Zero if update appears valid, error code on failure
*/
int drm_plane_helper_check_update(struct drm_plane *plane,
struct drm_crtc *crtc,
struct drm_framebuffer *fb,
struct drm_rect *src,
struct drm_rect *dst,
unsigned int rotation,
int min_scale,
int max_scale,
bool can_position,
bool can_update_disabled,
bool *visible)
{ {
struct drm_plane_state plane_state = { struct drm_plane_state plane_state = {
.plane = plane, .plane = plane,
...@@ -170,7 +144,6 @@ int drm_plane_helper_check_update(struct drm_plane *plane, ...@@ -170,7 +144,6 @@ int drm_plane_helper_check_update(struct drm_plane *plane,
return 0; return 0;
} }
EXPORT_SYMBOL(drm_plane_helper_check_update);
static int drm_primary_helper_update(struct drm_plane *plane, struct drm_crtc *crtc, static int drm_primary_helper_update(struct drm_plane *plane, struct drm_crtc *crtc,
struct drm_framebuffer *fb, struct drm_framebuffer *fb,
......
...@@ -38,17 +38,6 @@ ...@@ -38,17 +38,6 @@
*/ */
#define DRM_PLANE_HELPER_NO_SCALING (1<<16) #define DRM_PLANE_HELPER_NO_SCALING (1<<16)
int drm_plane_helper_check_update(struct drm_plane *plane,
struct drm_crtc *crtc,
struct drm_framebuffer *fb,
struct drm_rect *src,
struct drm_rect *dest,
unsigned int rotation,
int min_scale,
int max_scale,
bool can_position,
bool can_update_disabled,
bool *visible);
void drm_primary_helper_destroy(struct drm_plane *plane); void drm_primary_helper_destroy(struct drm_plane *plane);
extern const struct drm_plane_funcs drm_primary_helper_funcs; extern const struct drm_plane_funcs drm_primary_helper_funcs;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment