Commit 8564d4f2 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown

ASoC: amd: vangogh: acp5x-pcm-dma: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarTakashi Iwai <tiwai@suse.de>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-22-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 725d4edf
...@@ -415,10 +415,9 @@ static int acp5x_audio_probe(struct platform_device *pdev) ...@@ -415,10 +415,9 @@ static int acp5x_audio_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int acp5x_audio_remove(struct platform_device *pdev) static void acp5x_audio_remove(struct platform_device *pdev)
{ {
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
return 0;
} }
static int __maybe_unused acp5x_pcm_resume(struct device *dev) static int __maybe_unused acp5x_pcm_resume(struct device *dev)
...@@ -500,7 +499,7 @@ static const struct dev_pm_ops acp5x_pm_ops = { ...@@ -500,7 +499,7 @@ static const struct dev_pm_ops acp5x_pm_ops = {
static struct platform_driver acp5x_dma_driver = { static struct platform_driver acp5x_dma_driver = {
.probe = acp5x_audio_probe, .probe = acp5x_audio_probe,
.remove = acp5x_audio_remove, .remove_new = acp5x_audio_remove,
.driver = { .driver = {
.name = "acp5x_i2s_dma", .name = "acp5x_i2s_dma",
.pm = &acp5x_pm_ops, .pm = &acp5x_pm_ops,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment