Commit 86295cb4 authored by Alexander Gordeev's avatar Alexander Gordeev Committed by Vasily Gorbik

s390/kdump: cleanup do_start_kdump() prototype and usage

Avoid unnecessary run-time and compile-time type
conversions of do_start_kdump() function return
value and parameter.
Signed-off-by: default avatarAlexander Gordeev <agordeev@linux.ibm.com>
Reviewed-by: default avatarHeiko Carstens <hca@linux.ibm.com>
Signed-off-by: default avatarHeiko Carstens <hca@linux.ibm.com>
Signed-off-by: default avatarVasily Gorbik <gor@linux.ibm.com>
parent 7a04d491
...@@ -111,9 +111,8 @@ static noinline void __machine_kdump(void *image) ...@@ -111,9 +111,8 @@ static noinline void __machine_kdump(void *image)
store_status(__do_machine_kdump, image); store_status(__do_machine_kdump, image);
} }
static unsigned long do_start_kdump(unsigned long addr) static int do_start_kdump(struct kimage *image)
{ {
struct kimage *image = (struct kimage *) addr;
int (*start_kdump)(int) = (void *)image->start; int (*start_kdump)(int) = (void *)image->start;
int rc; int rc;
...@@ -134,8 +133,8 @@ static bool kdump_csum_valid(struct kimage *image) ...@@ -134,8 +133,8 @@ static bool kdump_csum_valid(struct kimage *image)
int rc; int rc;
preempt_disable(); preempt_disable();
rc = call_on_stack(1, S390_lowcore.nodat_stack, unsigned long, do_start_kdump, rc = call_on_stack(1, S390_lowcore.nodat_stack, int, do_start_kdump,
unsigned long, (unsigned long)image); struct kimage *, image);
preempt_enable(); preempt_enable();
return rc == 0; return rc == 0;
#else #else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment