Commit 865bfb2a authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by David S. Miller

net: bridge: Use array_size() helper in copy_to_user()

Use array_size() helper instead of the open-coded version in
copy_to_user(). These sorts of multiplication factors need
to be wrapped in array_size().

Link: https://github.com/KSPP/linux/issues/160Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ed717613
...@@ -71,7 +71,8 @@ static int get_fdb_entries(struct net_bridge *br, void __user *userbuf, ...@@ -71,7 +71,8 @@ static int get_fdb_entries(struct net_bridge *br, void __user *userbuf,
num = br_fdb_fillbuf(br, buf, maxnum, offset); num = br_fdb_fillbuf(br, buf, maxnum, offset);
if (num > 0) { if (num > 0) {
if (copy_to_user(userbuf, buf, num*sizeof(struct __fdb_entry))) if (copy_to_user(userbuf, buf,
array_size(num, sizeof(struct __fdb_entry))))
num = -EFAULT; num = -EFAULT;
} }
kfree(buf); kfree(buf);
...@@ -188,7 +189,7 @@ int br_dev_siocdevprivate(struct net_device *dev, struct ifreq *rq, void __user ...@@ -188,7 +189,7 @@ int br_dev_siocdevprivate(struct net_device *dev, struct ifreq *rq, void __user
return -ENOMEM; return -ENOMEM;
get_port_ifindices(br, indices, num); get_port_ifindices(br, indices, num);
if (copy_to_user(argp, indices, num * sizeof(int))) if (copy_to_user(argp, indices, array_size(num, sizeof(int))))
num = -EFAULT; num = -EFAULT;
kfree(indices); kfree(indices);
return num; return num;
...@@ -336,7 +337,8 @@ static int old_deviceless(struct net *net, void __user *uarg) ...@@ -336,7 +337,8 @@ static int old_deviceless(struct net *net, void __user *uarg)
args[2] = get_bridge_ifindices(net, indices, args[2]); args[2] = get_bridge_ifindices(net, indices, args[2]);
ret = copy_to_user(uarg, indices, args[2]*sizeof(int)) ret = copy_to_user(uarg, indices,
array_size(args[2], sizeof(int)))
? -EFAULT : args[2]; ? -EFAULT : args[2];
kfree(indices); kfree(indices);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment