Commit 86e1d5ad authored by Johan Hovold's avatar Johan Hovold Committed by David S. Miller

net: ethernet: ti: cpsw: fix mdio device reference leak

Make sure to drop the reference taken by of_find_device_by_node() when
looking up an mdio device from a phy_id property during probe.

Fixes: 549985ee ("cpsw: simplify the setup of the register
pointers")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c46ab7e0
...@@ -2397,6 +2397,7 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data, ...@@ -2397,6 +2397,7 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data,
} }
snprintf(slave_data->phy_id, sizeof(slave_data->phy_id), snprintf(slave_data->phy_id, sizeof(slave_data->phy_id),
PHY_ID_FMT, mdio->name, phyid); PHY_ID_FMT, mdio->name, phyid);
put_device(&mdio->dev);
} else { } else {
dev_err(&pdev->dev, dev_err(&pdev->dev,
"No slave[%d] phy_id, phy-handle, or fixed-link property\n", "No slave[%d] phy_id, phy-handle, or fixed-link property\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment