Commit 8756b2ec authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown

ASoC: codecs: inno_rk3036: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarTakashi Iwai <tiwai@suse.de>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-49-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 516ef43d
...@@ -457,13 +457,11 @@ static int rk3036_codec_platform_probe(struct platform_device *pdev) ...@@ -457,13 +457,11 @@ static int rk3036_codec_platform_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int rk3036_codec_platform_remove(struct platform_device *pdev) static void rk3036_codec_platform_remove(struct platform_device *pdev)
{ {
struct rk3036_codec_priv *priv = dev_get_drvdata(&pdev->dev); struct rk3036_codec_priv *priv = dev_get_drvdata(&pdev->dev);
clk_disable_unprepare(priv->pclk); clk_disable_unprepare(priv->pclk);
return 0;
} }
static const struct of_device_id rk3036_codec_of_match[] __maybe_unused = { static const struct of_device_id rk3036_codec_of_match[] __maybe_unused = {
...@@ -478,7 +476,7 @@ static struct platform_driver rk3036_codec_platform_driver = { ...@@ -478,7 +476,7 @@ static struct platform_driver rk3036_codec_platform_driver = {
.of_match_table = of_match_ptr(rk3036_codec_of_match), .of_match_table = of_match_ptr(rk3036_codec_of_match),
}, },
.probe = rk3036_codec_platform_probe, .probe = rk3036_codec_platform_probe,
.remove = rk3036_codec_platform_remove, .remove_new = rk3036_codec_platform_remove,
}; };
module_platform_driver(rk3036_codec_platform_driver); module_platform_driver(rk3036_codec_platform_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment