Commit 87b626a6 authored by Rob Herring's avatar Rob Herring Committed by Michael Ellerman

macintosh: Use of_property_present() for testing DT property presence

It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230310144735.1546817-1-robh@kernel.org
parent 4d57e351
...@@ -387,7 +387,7 @@ static int rackmeter_probe(struct macio_dev* mdev, ...@@ -387,7 +387,7 @@ static int rackmeter_probe(struct macio_dev* mdev,
if (of_node_name_eq(np, "lightshow")) if (of_node_name_eq(np, "lightshow"))
break; break;
if (of_node_name_eq(np, "sound") && if (of_node_name_eq(np, "sound") &&
of_get_property(np, "virtual", NULL) != NULL) of_property_present(np, "virtual"))
break; break;
} }
if (np == NULL) { if (np == NULL) {
......
...@@ -483,7 +483,7 @@ static int probe_thermostat(struct i2c_client *client) ...@@ -483,7 +483,7 @@ static int probe_thermostat(struct i2c_client *client)
if (vers != 1) if (vers != 1)
return -ENXIO; return -ENXIO;
if (of_get_property(np, "hwsensor-location", NULL)) { if (of_property_present(np, "hwsensor-location")) {
for (i = 0; i < 3; i++) { for (i = 0; i < 3; i++) {
sensor_location[i] = of_get_property(np, sensor_location[i] = of_get_property(np,
"hwsensor-location", NULL) + offset; "hwsensor-location", NULL) + offset;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment