Commit 88654d5b authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Michael Ellerman

powerpc/83xx: Add some error handling in 'quirk_mpc8360e_qe_enet10()'

In some error handling path, we should call "of_node_put(np_par)" or
some resource may be leaking in case of error.

Fixes: 8159df72 ("83xx: add support for the kmeter1 board.")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarScott Wood <oss@buserror.net>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200208140920.7652-1-christophe.jaillet@wanadoo.fr
parent 365ad0b6
...@@ -60,10 +60,12 @@ static void quirk_mpc8360e_qe_enet10(void) ...@@ -60,10 +60,12 @@ static void quirk_mpc8360e_qe_enet10(void)
ret = of_address_to_resource(np_par, 0, &res); ret = of_address_to_resource(np_par, 0, &res);
if (ret) { if (ret) {
pr_warn("%s couldn't map par_io registers\n", __func__); pr_warn("%s couldn't map par_io registers\n", __func__);
return; goto out;
} }
base = ioremap(res.start, resource_size(&res)); base = ioremap(res.start, resource_size(&res));
if (!base)
goto out;
/* /*
* set output delay adjustments to default values according * set output delay adjustments to default values according
...@@ -111,6 +113,7 @@ static void quirk_mpc8360e_qe_enet10(void) ...@@ -111,6 +113,7 @@ static void quirk_mpc8360e_qe_enet10(void)
setbits32((base + 0xac), 0x0000c000); setbits32((base + 0xac), 0x0000c000);
} }
iounmap(base); iounmap(base);
out:
of_node_put(np_par); of_node_put(np_par);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment