Commit 88a50c16 authored by Mark Brown's avatar Mark Brown

spi: Add support for stacked/parallel memories

Merge series from Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>:

This patch series adds support to the SPI framework for using multiple
chip selects.
parents 18f78b5e 4d8ff6b0
...@@ -98,7 +98,7 @@ static int tps6594_spi_probe(struct spi_device *spi) ...@@ -98,7 +98,7 @@ static int tps6594_spi_probe(struct spi_device *spi)
spi_set_drvdata(spi, tps); spi_set_drvdata(spi, tps);
tps->dev = dev; tps->dev = dev;
tps->reg = spi->chip_select; tps->reg = spi_get_chipselect(spi, 0);
tps->irq = spi->irq; tps->irq = spi->irq;
tps->regmap = devm_regmap_init(dev, NULL, spi, &tps6594_spi_regmap_config); tps->regmap = devm_regmap_init(dev, NULL, spi, &tps6594_spi_regmap_config);
......
This diff is collapsed.
...@@ -20,6 +20,9 @@ ...@@ -20,6 +20,9 @@
#include <uapi/linux/spi/spi.h> #include <uapi/linux/spi/spi.h>
/* Max no. of CS supported per spi device */
#define SPI_CS_CNT_MAX 4
struct dma_chan; struct dma_chan;
struct software_node; struct software_node;
struct ptp_system_timestamp; struct ptp_system_timestamp;
...@@ -132,7 +135,8 @@ extern void spi_transfer_cs_change_delay_exec(struct spi_message *msg, ...@@ -132,7 +135,8 @@ extern void spi_transfer_cs_change_delay_exec(struct spi_message *msg,
* @max_speed_hz: Maximum clock rate to be used with this chip * @max_speed_hz: Maximum clock rate to be used with this chip
* (on this board); may be changed by the device's driver. * (on this board); may be changed by the device's driver.
* The spi_transfer.speed_hz can override this for each transfer. * The spi_transfer.speed_hz can override this for each transfer.
* @chip_select: Chipselect, distinguishing chips handled by @controller. * @chip_select: Array of physical chipselect, spi->chipselect[i] gives
* the corresponding physical CS for logical CS i.
* @mode: The spi mode defines how data is clocked out and in. * @mode: The spi mode defines how data is clocked out and in.
* This may be changed by the device's driver. * This may be changed by the device's driver.
* The "active low" default for chipselect mode can be overridden * The "active low" default for chipselect mode can be overridden
...@@ -157,8 +161,8 @@ extern void spi_transfer_cs_change_delay_exec(struct spi_message *msg, ...@@ -157,8 +161,8 @@ extern void spi_transfer_cs_change_delay_exec(struct spi_message *msg,
* the device will bind to the named driver and only the named driver. * the device will bind to the named driver and only the named driver.
* Do not set directly, because core frees it; use driver_set_override() to * Do not set directly, because core frees it; use driver_set_override() to
* set or clear it. * set or clear it.
* @cs_gpiod: GPIO descriptor of the chipselect line (optional, NULL when * @cs_gpiod: Array of GPIO descriptors of the corresponding chipselect lines
* not using a GPIO line) * (optional, NULL when not using a GPIO line)
* @word_delay: delay to be inserted between consecutive * @word_delay: delay to be inserted between consecutive
* words of a transfer * words of a transfer
* @cs_setup: delay to be introduced by the controller after CS is asserted * @cs_setup: delay to be introduced by the controller after CS is asserted
...@@ -167,6 +171,7 @@ extern void spi_transfer_cs_change_delay_exec(struct spi_message *msg, ...@@ -167,6 +171,7 @@ extern void spi_transfer_cs_change_delay_exec(struct spi_message *msg,
* deasserted. If @cs_change_delay is used from @spi_transfer, then the * deasserted. If @cs_change_delay is used from @spi_transfer, then the
* two delays will be added up. * two delays will be added up.
* @pcpu_statistics: statistics for the spi_device * @pcpu_statistics: statistics for the spi_device
* @cs_index_mask: Bit mask of the active chipselect(s) in the chipselect array
* *
* A @spi_device is used to interchange data between an SPI slave * A @spi_device is used to interchange data between an SPI slave
* (usually a discrete chip) and CPU memory. * (usually a discrete chip) and CPU memory.
...@@ -182,7 +187,7 @@ struct spi_device { ...@@ -182,7 +187,7 @@ struct spi_device {
struct spi_controller *controller; struct spi_controller *controller;
struct spi_controller *master; /* Compatibility layer */ struct spi_controller *master; /* Compatibility layer */
u32 max_speed_hz; u32 max_speed_hz;
u8 chip_select; u8 chip_select[SPI_CS_CNT_MAX];
u8 bits_per_word; u8 bits_per_word;
bool rt; bool rt;
#define SPI_NO_TX BIT(31) /* No transmit wire */ #define SPI_NO_TX BIT(31) /* No transmit wire */
...@@ -213,7 +218,7 @@ struct spi_device { ...@@ -213,7 +218,7 @@ struct spi_device {
void *controller_data; void *controller_data;
char modalias[SPI_NAME_SIZE]; char modalias[SPI_NAME_SIZE];
const char *driver_override; const char *driver_override;
struct gpio_desc *cs_gpiod; /* Chip select GPIO descriptor */ struct gpio_desc *cs_gpiod[SPI_CS_CNT_MAX]; /* Chip select gpio desc */
struct spi_delay word_delay; /* Inter-word delay */ struct spi_delay word_delay; /* Inter-word delay */
/* CS delays */ /* CS delays */
struct spi_delay cs_setup; struct spi_delay cs_setup;
...@@ -223,6 +228,13 @@ struct spi_device { ...@@ -223,6 +228,13 @@ struct spi_device {
/* The statistics */ /* The statistics */
struct spi_statistics __percpu *pcpu_statistics; struct spi_statistics __percpu *pcpu_statistics;
/* Bit mask of the chipselect(s) that the driver need to use from
* the chipselect array.When the controller is capable to handle
* multiple chip selects & memories are connected in parallel
* then more than one bit need to be set in cs_index_mask.
*/
u32 cs_index_mask : SPI_CS_CNT_MAX;
/* /*
* Likely need more hooks for more protocol options affecting how * Likely need more hooks for more protocol options affecting how
* the controller talks to each chip, like: * the controller talks to each chip, like:
...@@ -279,22 +291,33 @@ static inline void *spi_get_drvdata(const struct spi_device *spi) ...@@ -279,22 +291,33 @@ static inline void *spi_get_drvdata(const struct spi_device *spi)
static inline u8 spi_get_chipselect(const struct spi_device *spi, u8 idx) static inline u8 spi_get_chipselect(const struct spi_device *spi, u8 idx)
{ {
return spi->chip_select; return spi->chip_select[idx];
} }
static inline void spi_set_chipselect(struct spi_device *spi, u8 idx, u8 chipselect) static inline void spi_set_chipselect(struct spi_device *spi, u8 idx, u8 chipselect)
{ {
spi->chip_select = chipselect; spi->chip_select[idx] = chipselect;
} }
static inline struct gpio_desc *spi_get_csgpiod(const struct spi_device *spi, u8 idx) static inline struct gpio_desc *spi_get_csgpiod(const struct spi_device *spi, u8 idx)
{ {
return spi->cs_gpiod; return spi->cs_gpiod[idx];
} }
static inline void spi_set_csgpiod(struct spi_device *spi, u8 idx, struct gpio_desc *csgpiod) static inline void spi_set_csgpiod(struct spi_device *spi, u8 idx, struct gpio_desc *csgpiod)
{ {
spi->cs_gpiod = csgpiod; spi->cs_gpiod[idx] = csgpiod;
}
static inline bool spi_is_csgpiod(struct spi_device *spi)
{
u8 idx;
for (idx = 0; idx < SPI_CS_CNT_MAX; idx++) {
if (spi_get_csgpiod(spi, idx))
return true;
}
return false;
} }
/** /**
...@@ -399,6 +422,8 @@ extern struct spi_device *spi_new_ancillary_device(struct spi_device *spi, u8 ch ...@@ -399,6 +422,8 @@ extern struct spi_device *spi_new_ancillary_device(struct spi_device *spi, u8 ch
* @bus_lock_spinlock: spinlock for SPI bus locking * @bus_lock_spinlock: spinlock for SPI bus locking
* @bus_lock_mutex: mutex for exclusion of multiple callers * @bus_lock_mutex: mutex for exclusion of multiple callers
* @bus_lock_flag: indicates that the SPI bus is locked for exclusive use * @bus_lock_flag: indicates that the SPI bus is locked for exclusive use
* @multi_cs_cap: indicates that the SPI Controller can assert/de-assert
* more than one chip select at once.
* @setup: updates the device mode and clocking records used by a * @setup: updates the device mode and clocking records used by a
* device's SPI controller; protocol code may call this. This * device's SPI controller; protocol code may call this. This
* must fail if an unrecognized or unsupported mode is requested. * must fail if an unrecognized or unsupported mode is requested.
...@@ -570,6 +595,11 @@ struct spi_controller { ...@@ -570,6 +595,11 @@ struct spi_controller {
#define SPI_CONTROLLER_MUST_TX BIT(4) /* Requires tx */ #define SPI_CONTROLLER_MUST_TX BIT(4) /* Requires tx */
#define SPI_CONTROLLER_GPIO_SS BIT(5) /* GPIO CS must select slave */ #define SPI_CONTROLLER_GPIO_SS BIT(5) /* GPIO CS must select slave */
#define SPI_CONTROLLER_SUSPENDED BIT(6) /* Currently suspended */ #define SPI_CONTROLLER_SUSPENDED BIT(6) /* Currently suspended */
/*
* The spi-controller has multi chip select capability and can
* assert/de-assert more than one chip select at once.
*/
#define SPI_CONTROLLER_MULTI_CS BIT(7)
/* Flag indicating if the allocation of this struct is devres-managed */ /* Flag indicating if the allocation of this struct is devres-managed */
bool devm_allocated; bool devm_allocated;
...@@ -680,7 +710,8 @@ struct spi_controller { ...@@ -680,7 +710,8 @@ struct spi_controller {
bool rt; bool rt;
bool auto_runtime_pm; bool auto_runtime_pm;
bool cur_msg_mapped; bool cur_msg_mapped;
char last_cs; char last_cs[SPI_CS_CNT_MAX];
char last_cs_index_mask;
bool last_cs_mode_high; bool last_cs_mode_high;
bool fallback; bool fallback;
struct completion xfer_completion; struct completion xfer_completion;
......
...@@ -29,7 +29,7 @@ static int cs35l56_hda_spi_probe(struct spi_device *spi) ...@@ -29,7 +29,7 @@ static int cs35l56_hda_spi_probe(struct spi_device *spi)
return ret; return ret;
} }
ret = cs35l56_hda_common_probe(cs35l56, spi->chip_select); ret = cs35l56_hda_common_probe(cs35l56, spi_get_chipselect(spi, 0));
if (ret) if (ret)
return ret; return ret;
ret = cs35l56_irq_request(&cs35l56->base, spi->irq); ret = cs35l56_irq_request(&cs35l56->base, spi->irq);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment