Commit 88ad32a7 authored by Manfred Spraul's avatar Manfred Spraul Committed by Andrew Morton

include/linux/percpu_counter.h: race in uniprocessor percpu_counter_add()

The percpu interface is supposed to be preempt and irq safe.

But:
The uniprocessor implementation of percpu_counter_add() is not irq safe:
if an interrupt happens during the +=, then the result is undefined.

Therefore: switch from preempt_disable() to local_irq_save().
This prevents interrupts from interrupting the +=, and as a side effect
prevents preemption.

Link: https://lkml.kernel.org/r/20221216150441.200533-2-manfred@colorfullife.comSigned-off-by: default avatarManfred Spraul <manfred@colorfullife.com>
Cc: "Sun, Jiebin" <jiebin.sun@intel.com>
Cc: <1vier1@web.de>
Cc: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 805afd83
...@@ -152,9 +152,11 @@ __percpu_counter_compare(struct percpu_counter *fbc, s64 rhs, s32 batch) ...@@ -152,9 +152,11 @@ __percpu_counter_compare(struct percpu_counter *fbc, s64 rhs, s32 batch)
static inline void static inline void
percpu_counter_add(struct percpu_counter *fbc, s64 amount) percpu_counter_add(struct percpu_counter *fbc, s64 amount)
{ {
preempt_disable(); unsigned long flags;
local_irq_save(flags);
fbc->count += amount; fbc->count += amount;
preempt_enable(); local_irq_restore(flags);
} }
/* non-SMP percpu_counter_add_local is the same with percpu_counter_add */ /* non-SMP percpu_counter_add_local is the same with percpu_counter_add */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment