Commit 89388f87 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Linus Walleij

pinctrl/rockchip: Add missing of_node_put() in rockchip_pinctrl_probe

The device_node pointer is returned by of_parse_phandle()  with refcount
incremented. We should use of_node_put() on it when done.

Fixes: 1e747e59 ("pinctrl: rockchip: base regmap supplied by a syscon")
Fixes: 14dee867 ("pinctrl: rockchip: let pmu registers be supplied by a syscon")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220307120234.28657-1-linmq006@gmail.comSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent c09ac191
...@@ -2693,6 +2693,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev) ...@@ -2693,6 +2693,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)
node = of_parse_phandle(np, "rockchip,grf", 0); node = of_parse_phandle(np, "rockchip,grf", 0);
if (node) { if (node) {
info->regmap_base = syscon_node_to_regmap(node); info->regmap_base = syscon_node_to_regmap(node);
of_node_put(node);
if (IS_ERR(info->regmap_base)) if (IS_ERR(info->regmap_base))
return PTR_ERR(info->regmap_base); return PTR_ERR(info->regmap_base);
} else { } else {
...@@ -2725,6 +2726,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev) ...@@ -2725,6 +2726,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)
node = of_parse_phandle(np, "rockchip,pmu", 0); node = of_parse_phandle(np, "rockchip,pmu", 0);
if (node) { if (node) {
info->regmap_pmu = syscon_node_to_regmap(node); info->regmap_pmu = syscon_node_to_regmap(node);
of_node_put(node);
if (IS_ERR(info->regmap_pmu)) if (IS_ERR(info->regmap_pmu))
return PTR_ERR(info->regmap_pmu); return PTR_ERR(info->regmap_pmu);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment