Commit 8974a86d authored by Randy Dunlap's avatar Randy Dunlap Committed by Greg Kroah-Hartman

virt: vbox: core: fix all kernel-doc warnings

Use kernel-doc format for functions that have comments that begin
with "/**".
This prevents 26 kernel-doc warnings.
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20231222052521.14333-1-rdunlap@infradead.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7037f714
...@@ -33,16 +33,15 @@ ...@@ -33,16 +33,15 @@
VMMDEV_REQUESTOR_CON_DONT_KNOW | VMMDEV_REQUESTOR_TRUST_NOT_GIVEN) VMMDEV_REQUESTOR_CON_DONT_KNOW | VMMDEV_REQUESTOR_TRUST_NOT_GIVEN)
/** /**
* Reserves memory in which the VMM can relocate any guest mappings * vbg_guest_mappings_init - Reserves memory in which the VMM can
* that are floating around. * relocate any guest mappings that are floating around.
* @gdev: The Guest extension device.
* *
* This operation is a little bit tricky since the VMM might not accept * This operation is a little bit tricky since the VMM might not accept
* just any address because of address clashes between the three contexts * just any address because of address clashes between the three contexts
* it operates in, so we try several times. * it operates in, so we try several times.
* *
* Failure to reserve the guest mappings is ignored. * Failure to reserve the guest mappings is ignored.
*
* @gdev: The Guest extension device.
*/ */
static void vbg_guest_mappings_init(struct vbg_dev *gdev) static void vbg_guest_mappings_init(struct vbg_dev *gdev)
{ {
...@@ -125,7 +124,7 @@ static void vbg_guest_mappings_init(struct vbg_dev *gdev) ...@@ -125,7 +124,7 @@ static void vbg_guest_mappings_init(struct vbg_dev *gdev)
} }
/** /**
* Undo what vbg_guest_mappings_init did. * vbg_guest_mappings_exit - Undo what vbg_guest_mappings_init did.
* *
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
*/ */
...@@ -166,9 +165,10 @@ static void vbg_guest_mappings_exit(struct vbg_dev *gdev) ...@@ -166,9 +165,10 @@ static void vbg_guest_mappings_exit(struct vbg_dev *gdev)
} }
/** /**
* Report the guest information to the host. * vbg_report_guest_info - Report the guest information to the host.
* Return: 0 or negative errno value.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
*
* Return: %0 or negative errno value.
*/ */
static int vbg_report_guest_info(struct vbg_dev *gdev) static int vbg_report_guest_info(struct vbg_dev *gdev)
{ {
...@@ -229,10 +229,11 @@ static int vbg_report_guest_info(struct vbg_dev *gdev) ...@@ -229,10 +229,11 @@ static int vbg_report_guest_info(struct vbg_dev *gdev)
} }
/** /**
* Report the guest driver status to the host. * vbg_report_driver_status - Report the guest driver status to the host.
* Return: 0 or negative errno value.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
* @active: Flag whether the driver is now active or not. * @active: Flag whether the driver is now active or not.
*
* Return: 0 or negative errno value.
*/ */
static int vbg_report_driver_status(struct vbg_dev *gdev, bool active) static int vbg_report_driver_status(struct vbg_dev *gdev, bool active)
{ {
...@@ -261,10 +262,12 @@ static int vbg_report_driver_status(struct vbg_dev *gdev, bool active) ...@@ -261,10 +262,12 @@ static int vbg_report_driver_status(struct vbg_dev *gdev, bool active)
} }
/** /**
* Inflate the balloon by one chunk. The caller owns the balloon mutex. * vbg_balloon_inflate - Inflate the balloon by one chunk. The caller
* Return: 0 or negative errno value. * owns the balloon mutex.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
* @chunk_idx: Index of the chunk. * @chunk_idx: Index of the chunk.
*
* Return: %0 or negative errno value.
*/ */
static int vbg_balloon_inflate(struct vbg_dev *gdev, u32 chunk_idx) static int vbg_balloon_inflate(struct vbg_dev *gdev, u32 chunk_idx)
{ {
...@@ -312,10 +315,12 @@ static int vbg_balloon_inflate(struct vbg_dev *gdev, u32 chunk_idx) ...@@ -312,10 +315,12 @@ static int vbg_balloon_inflate(struct vbg_dev *gdev, u32 chunk_idx)
} }
/** /**
* Deflate the balloon by one chunk. The caller owns the balloon mutex. * vbg_balloon_deflate - Deflate the balloon by one chunk. The caller
* Return: 0 or negative errno value. * owns the balloon mutex.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
* @chunk_idx: Index of the chunk. * @chunk_idx: Index of the chunk.
*
* Return: %0 or negative errno value.
*/ */
static int vbg_balloon_deflate(struct vbg_dev *gdev, u32 chunk_idx) static int vbg_balloon_deflate(struct vbg_dev *gdev, u32 chunk_idx)
{ {
...@@ -344,7 +349,7 @@ static int vbg_balloon_deflate(struct vbg_dev *gdev, u32 chunk_idx) ...@@ -344,7 +349,7 @@ static int vbg_balloon_deflate(struct vbg_dev *gdev, u32 chunk_idx)
return 0; return 0;
} }
/** /*
* Respond to VMMDEV_EVENT_BALLOON_CHANGE_REQUEST events, query the size * Respond to VMMDEV_EVENT_BALLOON_CHANGE_REQUEST events, query the size
* the host wants the balloon to be and adjust accordingly. * the host wants the balloon to be and adjust accordingly.
*/ */
...@@ -409,7 +414,7 @@ static void vbg_balloon_work(struct work_struct *work) ...@@ -409,7 +414,7 @@ static void vbg_balloon_work(struct work_struct *work)
} }
} }
/** /*
* Callback for heartbeat timer. * Callback for heartbeat timer.
*/ */
static void vbg_heartbeat_timer(struct timer_list *t) static void vbg_heartbeat_timer(struct timer_list *t)
...@@ -422,11 +427,12 @@ static void vbg_heartbeat_timer(struct timer_list *t) ...@@ -422,11 +427,12 @@ static void vbg_heartbeat_timer(struct timer_list *t)
} }
/** /**
* Configure the host to check guest's heartbeat * vbg_heartbeat_host_config - Configure the host to check guest's heartbeat
* and get heartbeat interval from the host. * and get heartbeat interval from the host.
* Return: 0 or negative errno value.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
* @enabled: Set true to enable guest heartbeat checks on host. * @enabled: Set true to enable guest heartbeat checks on host.
*
* Return: %0 or negative errno value.
*/ */
static int vbg_heartbeat_host_config(struct vbg_dev *gdev, bool enabled) static int vbg_heartbeat_host_config(struct vbg_dev *gdev, bool enabled)
{ {
...@@ -449,9 +455,11 @@ static int vbg_heartbeat_host_config(struct vbg_dev *gdev, bool enabled) ...@@ -449,9 +455,11 @@ static int vbg_heartbeat_host_config(struct vbg_dev *gdev, bool enabled)
} }
/** /**
* Initializes the heartbeat timer. This feature may be disabled by the host. * vbg_heartbeat_init - Initializes the heartbeat timer. This feature
* Return: 0 or negative errno value. * may be disabled by the host.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
*
* Return: %0 or negative errno value.
*/ */
static int vbg_heartbeat_init(struct vbg_dev *gdev) static int vbg_heartbeat_init(struct vbg_dev *gdev)
{ {
...@@ -481,7 +489,8 @@ static int vbg_heartbeat_init(struct vbg_dev *gdev) ...@@ -481,7 +489,8 @@ static int vbg_heartbeat_init(struct vbg_dev *gdev)
} }
/** /**
* Cleanup hearbeat code, stop HB timer and disable host heartbeat checking. * vbg_heartbeat_exit - Cleanup heartbeat code, stop HB timer and disable
* host heartbeat checking.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
*/ */
static void vbg_heartbeat_exit(struct vbg_dev *gdev) static void vbg_heartbeat_exit(struct vbg_dev *gdev)
...@@ -493,11 +502,12 @@ static void vbg_heartbeat_exit(struct vbg_dev *gdev) ...@@ -493,11 +502,12 @@ static void vbg_heartbeat_exit(struct vbg_dev *gdev)
} }
/** /**
* Applies a change to the bit usage tracker. * vbg_track_bit_usage - Applies a change to the bit usage tracker.
* Return: true if the mask changed, false if not.
* @tracker: The bit usage tracker. * @tracker: The bit usage tracker.
* @changed: The bits to change. * @changed: The bits to change.
* @previous: The previous value of the bits. * @previous: The previous value of the bits.
*
* Return: %true if the mask changed, %false if not.
*/ */
static bool vbg_track_bit_usage(struct vbg_bit_usage_tracker *tracker, static bool vbg_track_bit_usage(struct vbg_bit_usage_tracker *tracker,
u32 changed, u32 previous) u32 changed, u32 previous)
...@@ -529,10 +539,12 @@ static bool vbg_track_bit_usage(struct vbg_bit_usage_tracker *tracker, ...@@ -529,10 +539,12 @@ static bool vbg_track_bit_usage(struct vbg_bit_usage_tracker *tracker,
} }
/** /**
* Init and termination worker for resetting the (host) event filter on the host * vbg_reset_host_event_filter - Init and termination worker for
* Return: 0 or negative errno value. * resetting the (host) event filter on the host
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
* @fixed_events: Fixed events (init time). * @fixed_events: Fixed events (init time).
*
* Return: %0 or negative errno value.
*/ */
static int vbg_reset_host_event_filter(struct vbg_dev *gdev, static int vbg_reset_host_event_filter(struct vbg_dev *gdev,
u32 fixed_events) u32 fixed_events)
...@@ -556,12 +568,8 @@ static int vbg_reset_host_event_filter(struct vbg_dev *gdev, ...@@ -556,12 +568,8 @@ static int vbg_reset_host_event_filter(struct vbg_dev *gdev,
} }
/** /**
* Changes the event filter mask for the given session. * vbg_set_session_event_filter - Changes the event filter mask for the
* * given session.
* This is called in response to VBG_IOCTL_CHANGE_FILTER_MASK as well as to
* do session cleanup. Takes the session mutex.
*
* Return: 0 or negative errno value.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
* @session: The session. * @session: The session.
* @or_mask: The events to add. * @or_mask: The events to add.
...@@ -570,6 +578,11 @@ static int vbg_reset_host_event_filter(struct vbg_dev *gdev, ...@@ -570,6 +578,11 @@ static int vbg_reset_host_event_filter(struct vbg_dev *gdev,
* This tweaks the error handling so we perform * This tweaks the error handling so we perform
* proper session cleanup even if the host * proper session cleanup even if the host
* misbehaves. * misbehaves.
*
* This is called in response to VBG_IOCTL_CHANGE_FILTER_MASK as well as to
* do session cleanup. Takes the session mutex.
*
* Return: 0 or negative errno value.
*/ */
static int vbg_set_session_event_filter(struct vbg_dev *gdev, static int vbg_set_session_event_filter(struct vbg_dev *gdev,
struct vbg_session *session, struct vbg_session *session,
...@@ -637,9 +650,11 @@ static int vbg_set_session_event_filter(struct vbg_dev *gdev, ...@@ -637,9 +650,11 @@ static int vbg_set_session_event_filter(struct vbg_dev *gdev,
} }
/** /**
* Init and termination worker for set guest capabilities to zero on the host. * vbg_reset_host_capabilities - Init and termination worker for set
* Return: 0 or negative errno value. * guest capabilities to zero on the host.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
*
* Return: %0 or negative errno value.
*/ */
static int vbg_reset_host_capabilities(struct vbg_dev *gdev) static int vbg_reset_host_capabilities(struct vbg_dev *gdev)
{ {
...@@ -662,12 +677,14 @@ static int vbg_reset_host_capabilities(struct vbg_dev *gdev) ...@@ -662,12 +677,14 @@ static int vbg_reset_host_capabilities(struct vbg_dev *gdev)
} }
/** /**
* Set guest capabilities on the host. * vbg_set_host_capabilities - Set guest capabilities on the host.
* Must be called with gdev->session_mutex hold.
* Return: 0 or negative errno value.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
* @session: The session. * @session: The session.
* @session_termination: Set if we're called by the session cleanup code. * @session_termination: Set if we're called by the session cleanup code.
*
* Must be called with gdev->session_mutex hold.
*
* Return: %0 or negative errno value.
*/ */
static int vbg_set_host_capabilities(struct vbg_dev *gdev, static int vbg_set_host_capabilities(struct vbg_dev *gdev,
struct vbg_session *session, struct vbg_session *session,
...@@ -704,9 +721,8 @@ static int vbg_set_host_capabilities(struct vbg_dev *gdev, ...@@ -704,9 +721,8 @@ static int vbg_set_host_capabilities(struct vbg_dev *gdev,
} }
/** /**
* Acquire (get exclusive access) guest capabilities for a session. * vbg_acquire_session_capabilities - Acquire (get exclusive access)
* Takes the session mutex. * guest capabilities for a session.
* Return: 0 or negative errno value.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
* @session: The session. * @session: The session.
* @flags: Flags (VBGL_IOC_AGC_FLAGS_XXX). * @flags: Flags (VBGL_IOC_AGC_FLAGS_XXX).
...@@ -716,6 +732,10 @@ static int vbg_set_host_capabilities(struct vbg_dev *gdev, ...@@ -716,6 +732,10 @@ static int vbg_set_host_capabilities(struct vbg_dev *gdev,
* This tweaks the error handling so we perform * This tweaks the error handling so we perform
* proper session cleanup even if the host * proper session cleanup even if the host
* misbehaves. * misbehaves.
*
* Takes the session mutex.
*
* Return: %0 or negative errno value.
*/ */
static int vbg_acquire_session_capabilities(struct vbg_dev *gdev, static int vbg_acquire_session_capabilities(struct vbg_dev *gdev,
struct vbg_session *session, struct vbg_session *session,
...@@ -811,8 +831,8 @@ static int vbg_acquire_session_capabilities(struct vbg_dev *gdev, ...@@ -811,8 +831,8 @@ static int vbg_acquire_session_capabilities(struct vbg_dev *gdev,
} }
/** /**
* Sets the guest capabilities for a session. Takes the session mutex. * vbg_set_session_capabilities - Sets the guest capabilities for a
* Return: 0 or negative errno value. * session. Takes the session mutex.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
* @session: The session. * @session: The session.
* @or_mask: The capabilities to add. * @or_mask: The capabilities to add.
...@@ -821,6 +841,8 @@ static int vbg_acquire_session_capabilities(struct vbg_dev *gdev, ...@@ -821,6 +841,8 @@ static int vbg_acquire_session_capabilities(struct vbg_dev *gdev,
* This tweaks the error handling so we perform * This tweaks the error handling so we perform
* proper session cleanup even if the host * proper session cleanup even if the host
* misbehaves. * misbehaves.
*
* Return: %0 or negative errno value.
*/ */
static int vbg_set_session_capabilities(struct vbg_dev *gdev, static int vbg_set_session_capabilities(struct vbg_dev *gdev,
struct vbg_session *session, struct vbg_session *session,
...@@ -866,9 +888,10 @@ static int vbg_set_session_capabilities(struct vbg_dev *gdev, ...@@ -866,9 +888,10 @@ static int vbg_set_session_capabilities(struct vbg_dev *gdev,
} }
/** /**
* vbg_query_host_version get the host feature mask and version information. * vbg_query_host_version - get the host feature mask and version information.
* Return: 0 or negative errno value.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
*
* Return: %0 or negative errno value.
*/ */
static int vbg_query_host_version(struct vbg_dev *gdev) static int vbg_query_host_version(struct vbg_dev *gdev)
{ {
...@@ -905,19 +928,18 @@ static int vbg_query_host_version(struct vbg_dev *gdev) ...@@ -905,19 +928,18 @@ static int vbg_query_host_version(struct vbg_dev *gdev)
} }
/** /**
* Initializes the VBoxGuest device extension when the * vbg_core_init - Initializes the VBoxGuest device extension when the
* device driver is loaded. * device driver is loaded.
* @gdev: The Guest extension device.
* @fixed_events: Events that will be enabled upon init and no client
* will ever be allowed to mask.
* *
* The native code locates the VMMDev on the PCI bus and retrieve * The native code locates the VMMDev on the PCI bus and retrieve
* the MMIO and I/O port ranges, this function will take care of * the MMIO and I/O port ranges, this function will take care of
* mapping the MMIO memory (if present). Upon successful return * mapping the MMIO memory (if present). Upon successful return
* the native code should set up the interrupt handler. * the native code should set up the interrupt handler.
* *
* Return: 0 or negative errno value. * Return: %0 or negative errno value.
*
* @gdev: The Guest extension device.
* @fixed_events: Events that will be enabled upon init and no client
* will ever be allowed to mask.
*/ */
int vbg_core_init(struct vbg_dev *gdev, u32 fixed_events) int vbg_core_init(struct vbg_dev *gdev, u32 fixed_events)
{ {
...@@ -1017,11 +1039,12 @@ int vbg_core_init(struct vbg_dev *gdev, u32 fixed_events) ...@@ -1017,11 +1039,12 @@ int vbg_core_init(struct vbg_dev *gdev, u32 fixed_events)
} }
/** /**
* Call this on exit to clean-up vboxguest-core managed resources. * vbg_core_exit - Call this on exit to clean-up vboxguest-core managed
* resources.
* @gdev: The Guest extension device.
* *
* The native code should call this before the driver is loaded, * The native code should call this before the driver is loaded,
* but don't call this on shutdown. * but don't call this on shutdown.
* @gdev: The Guest extension device.
*/ */
void vbg_core_exit(struct vbg_dev *gdev) void vbg_core_exit(struct vbg_dev *gdev)
{ {
...@@ -1046,12 +1069,13 @@ void vbg_core_exit(struct vbg_dev *gdev) ...@@ -1046,12 +1069,13 @@ void vbg_core_exit(struct vbg_dev *gdev)
} }
/** /**
* Creates a VBoxGuest user session. * vbg_core_open_session - Creates a VBoxGuest user session.
* @gdev: The Guest extension device.
* @requestor: VMMDEV_REQUESTOR_* flags
* *
* vboxguest_linux.c calls this when userspace opens the char-device. * vboxguest_linux.c calls this when userspace opens the char-device.
*
* Return: A pointer to the new session or an ERR_PTR on error. * Return: A pointer to the new session or an ERR_PTR on error.
* @gdev: The Guest extension device.
* @requestor: VMMDEV_REQUESTOR_* flags
*/ */
struct vbg_session *vbg_core_open_session(struct vbg_dev *gdev, u32 requestor) struct vbg_session *vbg_core_open_session(struct vbg_dev *gdev, u32 requestor)
{ {
...@@ -1068,7 +1092,7 @@ struct vbg_session *vbg_core_open_session(struct vbg_dev *gdev, u32 requestor) ...@@ -1068,7 +1092,7 @@ struct vbg_session *vbg_core_open_session(struct vbg_dev *gdev, u32 requestor)
} }
/** /**
* Closes a VBoxGuest session. * vbg_core_close_session - Closes a VBoxGuest session.
* @session: The session to close (and free). * @session: The session to close (and free).
*/ */
void vbg_core_close_session(struct vbg_session *session) void vbg_core_close_session(struct vbg_session *session)
...@@ -1250,11 +1274,13 @@ static int vbg_ioctl_interrupt_all_wait_events(struct vbg_dev *gdev, ...@@ -1250,11 +1274,13 @@ static int vbg_ioctl_interrupt_all_wait_events(struct vbg_dev *gdev,
} }
/** /**
* Checks if the VMM request is allowed in the context of the given session. * vbg_req_allowed - Checks if the VMM request is allowed in the
* Return: 0 or negative errno value. * context of the given session.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
* @session: The calling session. * @session: The calling session.
* @req: The request. * @req: The request.
*
* Return: %0 or negative errno value.
*/ */
static int vbg_req_allowed(struct vbg_dev *gdev, struct vbg_session *session, static int vbg_req_allowed(struct vbg_dev *gdev, struct vbg_session *session,
const struct vmmdev_request_header *req) const struct vmmdev_request_header *req)
...@@ -1670,11 +1696,12 @@ static int vbg_ioctl_write_core_dump(struct vbg_dev *gdev, ...@@ -1670,11 +1696,12 @@ static int vbg_ioctl_write_core_dump(struct vbg_dev *gdev,
} }
/** /**
* Common IOCtl for user to kernel communication. * vbg_core_ioctl - Common IOCtl for user to kernel communication.
* Return: 0 or negative errno value.
* @session: The client session. * @session: The client session.
* @req: The requested function. * @req: The requested function.
* @data: The i/o data buffer, minimum size sizeof(struct vbg_ioctl_hdr). * @data: The i/o data buffer, minimum size sizeof(struct vbg_ioctl_hdr).
*
* Return: %0 or negative errno value.
*/ */
int vbg_core_ioctl(struct vbg_session *session, unsigned int req, void *data) int vbg_core_ioctl(struct vbg_session *session, unsigned int req, void *data)
{ {
...@@ -1744,11 +1771,12 @@ int vbg_core_ioctl(struct vbg_session *session, unsigned int req, void *data) ...@@ -1744,11 +1771,12 @@ int vbg_core_ioctl(struct vbg_session *session, unsigned int req, void *data)
} }
/** /**
* Report guest supported mouse-features to the host. * vbg_core_set_mouse_status - Report guest supported mouse-features to the host.
* *
* Return: 0 or negative errno value.
* @gdev: The Guest extension device. * @gdev: The Guest extension device.
* @features: The set of features to report to the host. * @features: The set of features to report to the host.
*
* Return: %0 or negative errno value.
*/ */
int vbg_core_set_mouse_status(struct vbg_dev *gdev, u32 features) int vbg_core_set_mouse_status(struct vbg_dev *gdev, u32 features)
{ {
...@@ -1772,7 +1800,7 @@ int vbg_core_set_mouse_status(struct vbg_dev *gdev, u32 features) ...@@ -1772,7 +1800,7 @@ int vbg_core_set_mouse_status(struct vbg_dev *gdev, u32 features)
return vbg_status_code_to_errno(rc); return vbg_status_code_to_errno(rc);
} }
/** Core interrupt service routine. */ /* Core interrupt service routine. */
irqreturn_t vbg_core_isr(int irq, void *dev_id) irqreturn_t vbg_core_isr(int irq, void *dev_id)
{ {
struct vbg_dev *gdev = dev_id; struct vbg_dev *gdev = dev_id;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment