Commit 89fea04c authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Bartosz Golaszewski

gpiolib: of: fix a memory leak in of_gpio_flags_quirks()

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a break from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the break.
Issue found with Coccinelle.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
[Bartosz: tweaked the commit message]
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 541e4095
...@@ -161,6 +161,7 @@ static void of_gpio_flags_quirks(struct device_node *np, ...@@ -161,6 +161,7 @@ static void of_gpio_flags_quirks(struct device_node *np,
of_node_full_name(child)); of_node_full_name(child));
*flags |= OF_GPIO_ACTIVE_LOW; *flags |= OF_GPIO_ACTIVE_LOW;
} }
of_node_put(child);
break; break;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment