Commit 8a692fdb authored by Lee Jones's avatar Lee Jones Committed by Martin K. Petersen

scsi: myrs: Demote obvious misuse of kerneldoc to standard comment blocks

No attempt has been made to document any of the demoted functions here.

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/myrs.c:94: warning: Function parameter or member 'cmd_blk' not described in 'myrs_reset_cmd'
 drivers/scsi/myrs.c:105: warning: Function parameter or member 'cs' not described in 'myrs_qcmd'
 drivers/scsi/myrs.c:105: warning: Function parameter or member 'cmd_blk' not described in 'myrs_qcmd'
 drivers/scsi/myrs.c:130: warning: Function parameter or member 'cs' not described in 'myrs_exec_cmd'
 drivers/scsi/myrs.c:130: warning: Function parameter or member 'cmd_blk' not described in 'myrs_exec_cmd'
 drivers/scsi/myrs.c:149: warning: Function parameter or member 'cs' not described in 'myrs_report_progress'
 drivers/scsi/myrs.c:149: warning: Function parameter or member 'ldev_num' not described in 'myrs_report_progress'
 drivers/scsi/myrs.c:149: warning: Function parameter or member 'msg' not described in 'myrs_report_progress'
 drivers/scsi/myrs.c:149: warning: Function parameter or member 'blocks' not described in 'myrs_report_progress'
 drivers/scsi/myrs.c:149: warning: Function parameter or member 'size' not described in 'myrs_report_progress'
 drivers/scsi/myrs.c:160: warning: Function parameter or member 'cs' not described in 'myrs_get_ctlr_info'
 drivers/scsi/myrs.c:222: warning: Function parameter or member 'cs' not described in 'myrs_get_ldev_info'
 drivers/scsi/myrs.c:222: warning: Function parameter or member 'ldev_num' not described in 'myrs_get_ldev_info'
 drivers/scsi/myrs.c:222: warning: Function parameter or member 'ldev_info' not described in 'myrs_get_ldev_info'
 drivers/scsi/myrs.c:310: warning: Function parameter or member 'cs' not described in 'myrs_get_pdev_info'
 drivers/scsi/myrs.c:310: warning: Function parameter or member 'channel' not described in 'myrs_get_pdev_info'
 drivers/scsi/myrs.c:310: warning: Function parameter or member 'target' not described in 'myrs_get_pdev_info'
 drivers/scsi/myrs.c:310: warning: Function parameter or member 'lun' not described in 'myrs_get_pdev_info'
 drivers/scsi/myrs.c:310: warning: Function parameter or member 'pdev_info' not described in 'myrs_get_pdev_info'
 drivers/scsi/myrs.c:353: warning: Function parameter or member 'cs' not described in 'myrs_dev_op'
 drivers/scsi/myrs.c:353: warning: Function parameter or member 'opcode' not described in 'myrs_dev_op'
 drivers/scsi/myrs.c:353: warning: Function parameter or member 'opdev' not described in 'myrs_dev_op'
 drivers/scsi/myrs.c:379: warning: Function parameter or member 'cs' not described in 'myrs_translate_pdev'
 drivers/scsi/myrs.c:379: warning: Function parameter or member 'channel' not described in 'myrs_translate_pdev'
 drivers/scsi/myrs.c:379: warning: Function parameter or member 'target' not described in 'myrs_translate_pdev'
 drivers/scsi/myrs.c:379: warning: Function parameter or member 'lun' not described in 'myrs_translate_pdev'
 drivers/scsi/myrs.c:379: warning: Function parameter or member 'devmap' not described in 'myrs_translate_pdev'
 drivers/scsi/myrs.c:422: warning: Function parameter or member 'cs' not described in 'myrs_get_event'
 drivers/scsi/myrs.c:422: warning: Function parameter or member 'event_num' not described in 'myrs_get_event'
 drivers/scsi/myrs.c:422: warning: Function parameter or member 'event_buf' not described in 'myrs_get_event'
 drivers/scsi/myrs.c:484: warning: Function parameter or member 'cs' not described in 'myrs_enable_mmio_mbox'
 drivers/scsi/myrs.c:484: warning: Function parameter or member 'enable_mbox_fn' not described in 'myrs_enable_mmio_mbox'
 drivers/scsi/myrs.c:584: warning: Function parameter or member 'cs' not described in 'myrs_get_config'
 drivers/scsi/myrs.c:688: warning: cannot understand function prototype: 'struct '
 drivers/scsi/myrs.c:1967: warning: Function parameter or member 'dev' not described in 'myrs_is_raid'
 drivers/scsi/myrs.c:1980: warning: Function parameter or member 'dev' not described in 'myrs_get_resync'
 drivers/scsi/myrs.c:2005: warning: Function parameter or member 'dev' not described in 'myrs_get_state'
 drivers/scsi/myrs.c:2343: warning: bad line:   the Error Status Register when the driver performs the BIOS handshaking.
 drivers/scsi/myrs.c:2344: warning: bad line:   It returns true for fatal errors and false otherwise.
 drivers/scsi/myrs.c:2349: warning: Function parameter or member 'cs' not described in 'myrs_err_status'
 drivers/scsi/myrs.c:2349: warning: Function parameter or member 'status' not described in 'myrs_err_status'
 drivers/scsi/myrs.c:2349: warning: Function parameter or member 'parm0' not described in 'myrs_err_status'
 drivers/scsi/myrs.c:2349: warning: Function parameter or member 'parm1' not described in 'myrs_err_status'

Link: https://lore.kernel.org/r/20200713080001.128044-16-lee.jones@linaro.org
Cc: Hannes Reinecke <hare@kernel.org>
Cc: Linux GmbH <hare@suse.com>
Cc: "Leonard N. Zubkoff" <lnz@dandelion.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f3bdc59f
...@@ -87,7 +87,7 @@ static char *myrs_raid_level_name(enum myrs_raid_level level) ...@@ -87,7 +87,7 @@ static char *myrs_raid_level_name(enum myrs_raid_level level)
return NULL; return NULL;
} }
/** /*
* myrs_reset_cmd - clears critical fields in struct myrs_cmdblk * myrs_reset_cmd - clears critical fields in struct myrs_cmdblk
*/ */
static inline void myrs_reset_cmd(struct myrs_cmdblk *cmd_blk) static inline void myrs_reset_cmd(struct myrs_cmdblk *cmd_blk)
...@@ -98,7 +98,7 @@ static inline void myrs_reset_cmd(struct myrs_cmdblk *cmd_blk) ...@@ -98,7 +98,7 @@ static inline void myrs_reset_cmd(struct myrs_cmdblk *cmd_blk)
cmd_blk->status = 0; cmd_blk->status = 0;
} }
/** /*
* myrs_qcmd - queues Command for DAC960 V2 Series Controllers. * myrs_qcmd - queues Command for DAC960 V2 Series Controllers.
*/ */
static void myrs_qcmd(struct myrs_hba *cs, struct myrs_cmdblk *cmd_blk) static void myrs_qcmd(struct myrs_hba *cs, struct myrs_cmdblk *cmd_blk)
...@@ -122,7 +122,7 @@ static void myrs_qcmd(struct myrs_hba *cs, struct myrs_cmdblk *cmd_blk) ...@@ -122,7 +122,7 @@ static void myrs_qcmd(struct myrs_hba *cs, struct myrs_cmdblk *cmd_blk)
cs->next_cmd_mbox = next_mbox; cs->next_cmd_mbox = next_mbox;
} }
/** /*
* myrs_exec_cmd - executes V2 Command and waits for completion. * myrs_exec_cmd - executes V2 Command and waits for completion.
*/ */
static void myrs_exec_cmd(struct myrs_hba *cs, static void myrs_exec_cmd(struct myrs_hba *cs,
...@@ -140,7 +140,7 @@ static void myrs_exec_cmd(struct myrs_hba *cs, ...@@ -140,7 +140,7 @@ static void myrs_exec_cmd(struct myrs_hba *cs,
wait_for_completion(&complete); wait_for_completion(&complete);
} }
/** /*
* myrs_report_progress - prints progress message * myrs_report_progress - prints progress message
*/ */
static void myrs_report_progress(struct myrs_hba *cs, unsigned short ldev_num, static void myrs_report_progress(struct myrs_hba *cs, unsigned short ldev_num,
...@@ -153,7 +153,7 @@ static void myrs_report_progress(struct myrs_hba *cs, unsigned short ldev_num, ...@@ -153,7 +153,7 @@ static void myrs_report_progress(struct myrs_hba *cs, unsigned short ldev_num,
(100 * (int)(blocks >> 7)) / (int)(size >> 7)); (100 * (int)(blocks >> 7)) / (int)(size >> 7));
} }
/** /*
* myrs_get_ctlr_info - executes a Controller Information IOCTL Command * myrs_get_ctlr_info - executes a Controller Information IOCTL Command
*/ */
static unsigned char myrs_get_ctlr_info(struct myrs_hba *cs) static unsigned char myrs_get_ctlr_info(struct myrs_hba *cs)
...@@ -214,7 +214,7 @@ static unsigned char myrs_get_ctlr_info(struct myrs_hba *cs) ...@@ -214,7 +214,7 @@ static unsigned char myrs_get_ctlr_info(struct myrs_hba *cs)
return status; return status;
} }
/** /*
* myrs_get_ldev_info - executes a Logical Device Information IOCTL Command * myrs_get_ldev_info - executes a Logical Device Information IOCTL Command
*/ */
static unsigned char myrs_get_ldev_info(struct myrs_hba *cs, static unsigned char myrs_get_ldev_info(struct myrs_hba *cs,
...@@ -301,7 +301,7 @@ static unsigned char myrs_get_ldev_info(struct myrs_hba *cs, ...@@ -301,7 +301,7 @@ static unsigned char myrs_get_ldev_info(struct myrs_hba *cs,
return status; return status;
} }
/** /*
* myrs_get_pdev_info - executes a "Read Physical Device Information" Command * myrs_get_pdev_info - executes a "Read Physical Device Information" Command
*/ */
static unsigned char myrs_get_pdev_info(struct myrs_hba *cs, static unsigned char myrs_get_pdev_info(struct myrs_hba *cs,
...@@ -345,7 +345,7 @@ static unsigned char myrs_get_pdev_info(struct myrs_hba *cs, ...@@ -345,7 +345,7 @@ static unsigned char myrs_get_pdev_info(struct myrs_hba *cs,
return status; return status;
} }
/** /*
* myrs_dev_op - executes a "Device Operation" Command * myrs_dev_op - executes a "Device Operation" Command
*/ */
static unsigned char myrs_dev_op(struct myrs_hba *cs, static unsigned char myrs_dev_op(struct myrs_hba *cs,
...@@ -369,7 +369,7 @@ static unsigned char myrs_dev_op(struct myrs_hba *cs, ...@@ -369,7 +369,7 @@ static unsigned char myrs_dev_op(struct myrs_hba *cs,
return status; return status;
} }
/** /*
* myrs_translate_pdev - translates a Physical Device Channel and * myrs_translate_pdev - translates a Physical Device Channel and
* TargetID into a Logical Device. * TargetID into a Logical Device.
*/ */
...@@ -414,7 +414,7 @@ static unsigned char myrs_translate_pdev(struct myrs_hba *cs, ...@@ -414,7 +414,7 @@ static unsigned char myrs_translate_pdev(struct myrs_hba *cs,
return status; return status;
} }
/** /*
* myrs_get_event - executes a Get Event Command * myrs_get_event - executes a Get Event Command
*/ */
static unsigned char myrs_get_event(struct myrs_hba *cs, static unsigned char myrs_get_event(struct myrs_hba *cs,
...@@ -476,7 +476,7 @@ static unsigned char myrs_get_fwstatus(struct myrs_hba *cs) ...@@ -476,7 +476,7 @@ static unsigned char myrs_get_fwstatus(struct myrs_hba *cs)
return status; return status;
} }
/** /*
* myrs_enable_mmio_mbox - enables the Memory Mailbox Interface * myrs_enable_mmio_mbox - enables the Memory Mailbox Interface
*/ */
static bool myrs_enable_mmio_mbox(struct myrs_hba *cs, static bool myrs_enable_mmio_mbox(struct myrs_hba *cs,
...@@ -577,7 +577,7 @@ static bool myrs_enable_mmio_mbox(struct myrs_hba *cs, ...@@ -577,7 +577,7 @@ static bool myrs_enable_mmio_mbox(struct myrs_hba *cs,
return (status == MYRS_STATUS_SUCCESS); return (status == MYRS_STATUS_SUCCESS);
} }
/** /*
* myrs_get_config - reads the Configuration Information * myrs_get_config - reads the Configuration Information
*/ */
static int myrs_get_config(struct myrs_hba *cs) static int myrs_get_config(struct myrs_hba *cs)
...@@ -682,7 +682,7 @@ static int myrs_get_config(struct myrs_hba *cs) ...@@ -682,7 +682,7 @@ static int myrs_get_config(struct myrs_hba *cs)
return 0; return 0;
} }
/** /*
* myrs_log_event - prints a Controller Event message * myrs_log_event - prints a Controller Event message
*/ */
static struct { static struct {
...@@ -2338,11 +2338,11 @@ static struct myrs_hba *myrs_detect(struct pci_dev *pdev, ...@@ -2338,11 +2338,11 @@ static struct myrs_hba *myrs_detect(struct pci_dev *pdev,
return NULL; return NULL;
} }
/** /*
* myrs_err_status reports Controller BIOS Messages passed through * myrs_err_status reports Controller BIOS Messages passed through
the Error Status Register when the driver performs the BIOS handshaking. * the Error Status Register when the driver performs the BIOS handshaking.
It returns true for fatal errors and false otherwise. * It returns true for fatal errors and false otherwise.
*/ */
static bool myrs_err_status(struct myrs_hba *cs, unsigned char status, static bool myrs_err_status(struct myrs_hba *cs, unsigned char status,
unsigned char parm0, unsigned char parm1) unsigned char parm0, unsigned char parm1)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment