Commit 8a6ffcbe authored by Zenghui Yu's avatar Zenghui Yu Committed by Marc Zyngier

KVM: arm64: selftests: Fix multiple versions of GIC creation

Commit 98f94ce4 ("KVM: selftests: Move KVM_CREATE_DEVICE_TEST code to
separate helper") wrongly converted a "real" GIC device creation to
__kvm_test_create_device() and caused the test failure on my D05 (which
supports v2 emulation). Fix it.

Fixes: 98f94ce4 ("KVM: selftests: Move KVM_CREATE_DEVICE_TEST code to separate helper")
Signed-off-by: default avatarZenghui Yu <yuzenghui@huawei.com>
Reviewed-by: default avatarOliver Upton <oliver.upton@linux.dev>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20221009033131.365-1-yuzenghui@huawei.com
parent 837d632a
...@@ -662,8 +662,8 @@ int test_kvm_device(uint32_t gic_dev_type) ...@@ -662,8 +662,8 @@ int test_kvm_device(uint32_t gic_dev_type)
: KVM_DEV_TYPE_ARM_VGIC_V2; : KVM_DEV_TYPE_ARM_VGIC_V2;
if (!__kvm_test_create_device(v.vm, other)) { if (!__kvm_test_create_device(v.vm, other)) {
ret = __kvm_test_create_device(v.vm, other); ret = __kvm_create_device(v.vm, other);
TEST_ASSERT(ret && (errno == EINVAL || errno == EEXIST), TEST_ASSERT(ret < 0 && (errno == EINVAL || errno == EEXIST),
"create GIC device while other version exists"); "create GIC device while other version exists");
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment